Skip to content

feat(maths): is palindrome number#118

Merged
raklaptudirm merged 8 commits into
TheAlgorithms:masterfrom
zFl4wless:maths/is-palindrome
Mar 26, 2023
Merged

feat(maths): is palindrome number#118
raklaptudirm merged 8 commits into
TheAlgorithms:masterfrom
zFl4wless:maths/is-palindrome

Conversation

@zFl4wless

@zFl4wless zFl4wless commented Mar 22, 2023

Copy link
Copy Markdown
Contributor

Resolves requested changes and improves the already existing PR #93

appgurueu
appgurueu previously approved these changes Mar 22, 2023
Comment thread maths/is_palindrome.ts Outdated
@appgurueu

appgurueu commented Mar 24, 2023

Copy link
Copy Markdown
Contributor

As said:

One caveat: The reversed number might be much larger than the original number (e.g. 123456789 becomes 987654321). It is possible that the original number is below MAX_SAFE_INTEGER, but the reversed number isn't. Rounding errors will lead to a wrong result in that case (it could be considered an edge case however, and could be resolved by limiting the maximum integer further than MAX_SAFE_INTEGER).

Please at least document this limitation.

@zFl4wless zFl4wless removed the request for review from raklaptudirm March 25, 2023 10:00
@zFl4wless zFl4wless requested a review from appgurueu March 25, 2023 10:00
@zFl4wless zFl4wless requested a review from raklaptudirm March 25, 2023 22:32
@raklaptudirm raklaptudirm merged commit 7e23e1e into TheAlgorithms:master Mar 26, 2023
@zFl4wless zFl4wless deleted the maths/is-palindrome branch March 26, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants