Skip to content

style: enabled InnerAssignment in checkstyle #5162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vil02 merged 6 commits into from
May 16, 2024
Merged

style: enabled InnerAssignment in checkstyle #5162

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2c147e9
style: enabled InnerAssignment in checkstyle
CodaBlurd May 16, 2024
58c7a78
Refactor code formatting in KnapsackMemoization.java and UnionFind.java
CodaBlurd May 16, 2024
2dce946
style: remove redundant blank line
vil02 May 16, 2024
5320bec
style: mark `includeCurrentItem` and `excludeCurrentItem` as `final`
vil02 May 16, 2024
701abc9
style: remove `KnapsackMemoization` from `pmd-exclude.properties`
vil02 May 16, 2024
21e9a12
style: use `final`
vil02 May 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor code formatting in KnapsackMemoization.java and UnionFind.java
  • Loading branch information
@CodaBlurd
CodaBlurd committed May 16, 2024
commit 58c7a781095174808610f7802b6947491eef6595
4 changes: 2 additions & 2 deletions src/main/java/com/thealgorithms/dynamicprogramming/KnapsackMemoization.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ int solveKnapsackRecursive(int capacity, int[] weights, int[] profits, int numOf
return dpTable[numOfItems][capacity];
} else {
// case 1. include the item, if it is less than the capacity
int includeCurrentItem = profits[numOfItems - 1]
+ solveKnapsackRecursive(capacity - weights[numOfItems - 1], weights, profits, numOfItems - 1, dpTable);
int includeCurrentItem = profits[numOfItems - 1] + solveKnapsackRecursive(capacity - weights[numOfItems - 1], weights, profits, numOfItems - 1, dpTable);
Comment thread
vil02 marked this conversation as resolved.
Outdated


Comment thread
vil02 marked this conversation as resolved.
// case 2. exclude the item if it is more than the capacity
int excludeCurrentItem = solveKnapsackRecursive(capacity, weights, profits, numOfItems - 1, dpTable);
Comment thread
vil02 marked this conversation as resolved.
Outdated
Expand Down
5 changes: 3 additions & 2 deletions src/main/java/com/thealgorithms/searches/UnionFind.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,9 @@ public int find(int i) {
return i;
}

int result = find(parent);
p[i] = result;
int result = find(parent);
Comment thread
vil02 marked this conversation as resolved.
Outdated
p[i] = result;

return result;
}

Expand Down