style: enabled InnerAssignment in checkstyle#5162
Merged
vil02 merged 6 commits intoTheAlgorithms:masterfrom May 16, 2024
Merged
style: enabled InnerAssignment in checkstyle#5162vil02 merged 6 commits intoTheAlgorithms:masterfrom
InnerAssignment in checkstyle#5162vil02 merged 6 commits intoTheAlgorithms:masterfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5162 +/- ##
=========================================
Coverage 38.26% 38.27%
Complexity 2362 2362
=========================================
Files 516 516
Lines 15304 15322 +18
Branches 2956 2957 +1
=========================================
+ Hits 5856 5864 +8
- Misses 9164 9173 +9
- Partials 284 285 +1 ☔ View full report in Codecov by Sentry. |
vil02
requested changes
May 16, 2024
This should fix the clang-format error.
InnerAssignment in checkstyle
26 tasks
vil02
requested changes
May 16, 2024
vil02
reviewed
May 16, 2024
vil02
approved these changes
May 16, 2024
Member
vil02
left a comment
There was a problem hiding this comment.
Thanks!
I allowed myself to push few commits into your branch, I hope you don't mind.
Member
|
I will merge it as soon as codecov will allow it... |
Contributor
Author
|
No not at all. Thank you for helping me learn and improve! |
Member
|
Feel free to create PRs witch add missing tests, like #5160. This is the best way to find and fix bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #5119