Skip to content

Added function and fixed bug in PerfectCube.java #3655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
debasishbsws merged 6 commits into from
Oct 29, 2022
Merged

Added function and fixed bug in PerfectCube.java #3655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2a7cf3d
Added another function to PerfectCube.java
TaranjeetSinghKalsi Oct 25, 2022
938c89c
Created PerfectCubeTest.java
TaranjeetSinghKalsi Oct 25, 2022
db7575b
fixed PerfectCubeTest.java
TaranjeetSinghKalsi Oct 25, 2022
d7d63b5
Fixed bug in PerfectCube.java
TaranjeetSinghKalsi Oct 25, 2022
ce9c4eb
Merge branch 'master' into patch-7
TaranjeetSinghKalsi Oct 27, 2022
f52722a
removed main() in PerfectCube.java
TaranjeetSinghKalsi Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 13 additions & 9 deletions src/main/java/com/thealgorithms/maths/PerfectCube.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,6 @@
*/
public class PerfectCube {

public static void main(String[] args) {
assert !isPerfectCube(-1);
assert isPerfectCube(0);
assert isPerfectCube(1);
assert !isPerfectCube(4);
assert isPerfectCube(8);
assert isPerfectCube(27);
}

/**
* Check if a number is perfect cube or not
*
Expand All @@ -22,7 +13,20 @@ public static void main(String[] args) {
* {@code false}
*/
public static boolean isPerfectCube(int number) {
number = Math.abs(number); // converting negative number to positive number
int a = (int) Math.pow(number, 1.0 / 3);
return a * a * a == number;
}

/**
* Check if a number is perfect cube or not by using Math.cbrt function
*
* @param number number to check
* @return {@code true} if {@code number} is perfect cube, otherwise
* {@code false}
*/
public static boolean isPerfectCubeMathCbrt(int number) {
double cubeRoot = Math.cbrt(number);
return cubeRoot == (int) cubeRoot;
}
}
33 changes: 33 additions & 0 deletions src/test/java/com/thealgorithms/maths/PerfectCubeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
package com.thealgorithms.maths;

import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;

class PerfectCubeTest {

@Test
public void perfectCube() {

Assertions.assertTrue(PerfectCube.isPerfectCube(-27));
Assertions.assertTrue(PerfectCube.isPerfectCubeMathCbrt(-27));
Assertions.assertTrue(PerfectCube.isPerfectCube(-1));
Assertions.assertTrue(PerfectCube.isPerfectCubeMathCbrt(-1));
Assertions.assertTrue(PerfectCube.isPerfectCube(0));
Assertions.assertTrue(PerfectCube.isPerfectCubeMathCbrt(0));
Assertions.assertTrue(PerfectCube.isPerfectCube(1));
Assertions.assertTrue(PerfectCube.isPerfectCubeMathCbrt(1));
Assertions.assertTrue(PerfectCube.isPerfectCube(8));
Assertions.assertTrue(PerfectCube.isPerfectCubeMathCbrt(8));
Assertions.assertTrue(PerfectCube.isPerfectCube(27));
Assertions.assertTrue(PerfectCube.isPerfectCubeMathCbrt(27));

Assertions.assertFalse(PerfectCube.isPerfectCube(-9));
Assertions.assertFalse(PerfectCube.isPerfectCubeMathCbrt(-9));
Assertions.assertFalse(PerfectCube.isPerfectCube(2));
Assertions.assertFalse(PerfectCube.isPerfectCubeMathCbrt(2));
Assertions.assertFalse(PerfectCube.isPerfectCube(4));
Assertions.assertFalse(PerfectCube.isPerfectCubeMathCbrt(4));
Assertions.assertFalse(PerfectCube.isPerfectCube(30));
Assertions.assertFalse(PerfectCube.isPerfectCubeMathCbrt(30));
}
}