Added function and fixed bug in PerfectCube.java#3655
Merged
Conversation
Added another function to PerfectCube.java and fixed a testing mistake in line number 9
siriak
requested changes
Oct 25, 2022
siriak
left a comment
Member
There was a problem hiding this comment.
The code looks good, could you please add some JUnit tests? (see https://github.com/TheAlgorithms/Java/tree/master/src/test/java/com/thealgorithms)
Created PerfectCubeTest.java
Fixed bug in PerfectCube.java in isPerfectCube() function for negative numbers. Now It gives the correct output for perfect negative numbers.
Contributor
Author
Thanks, I have added JUnit tests and also fixed a bug in isPerfectCube() function for negative numbers. Kindly look after it. |
Contributor
Author
There was a problem hiding this comment.
Added Junit Tests. Kindly review it @siriak @yanglbme @debasishbsws
debasishbsws
requested changes
Oct 27, 2022
TaranjeetSinghKalsi
requested review from
debasishbsws and
siriak
and removed request for
debasishbsws and
siriak
October 27, 2022 19:17
Member
|
@debasishbsws please review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added another function to PerfectCube.java and fixed a testing mistake in line number 9
Fixes: #{$ISSUE_NO}.