Skip to content

String to StringBuilder in Others/PasswordGen.java #1470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
realDuYuanChao merged 2 commits into from
Sep 18, 2020
Merged

String to StringBuilder in Others/PasswordGen.java #1470

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0646f5e
Update README.md
arrnavvv Sep 17, 2020
ebdf7be
Update PasswordGen.java
arrnavvv Sep 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Others/PasswordGen.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,13 @@ static String generatePassword(int min_length, int max_length) {

// Inbuilt method to randomly shuffle a elements of a list
Collections.shuffle(letters);
String password = "";
StringBuilder password = new StringBuilder();

// Note that size of the password is also random
for (int i = random.nextInt(max_length - min_length) + min_length; i > 0; --i) {
password += letters.get(random.nextInt(letters.size()));
password .append( letters.get(random.nextInt(letters.size())));
}

return password;
return password.toString();
}
}
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ You can run and edit the algorithms or contribute to them using Gitpod.io, a fre
[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/#https://github.com/TheAlgorithms/Java)


### All algorithms are implemented in Java (for education purposes)
### All algorithms are implemented in Java (for educational purposes)
These implementations are for learning purposes. The implementations may be less efficient than the Java standard library.

## Contribution Guidelines
Expand Down