Skip to content

String to StringBuilder in Others/PasswordGen.java#1470

Merged
realDuYuanChao merged 2 commits into
TheAlgorithms:masterfrom
arrnavvv:master
Sep 18, 2020
Merged

String to StringBuilder in Others/PasswordGen.java#1470
realDuYuanChao merged 2 commits into
TheAlgorithms:masterfrom
arrnavvv:master

Conversation

@arrnavvv
Copy link
Copy Markdown
Contributor

Describe your change:

Used StringBuilder for the variable password instead of String as it was being modified with every iteration.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

References

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Java files are placed inside an existing directory.
  • All filenames are in all uppercase characters with no spaces or dashes.
  • All functions and variable names follow Java naming conventions.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Copy Markdown
Member

@realDuYuanChao realDuYuanChao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@realDuYuanChao realDuYuanChao merged commit 88ac7cf into TheAlgorithms:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants