Skip to content

feat: implement auditlog ng client #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeanscherf merged 20 commits into from
Apr 13, 2026
Merged

feat: implement auditlog ng client #41

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
fcc36e1
Implement Auditlog NG client
simeongelovski Apr 7, 2026
c66b14a
Address code review comments
simeongelovski Apr 8, 2026
4d8a150
Remove generated files
simeongelovski Apr 8, 2026
38fb184
Remove unused files files
simeongelovski Apr 8, 2026
faf7bc9
Remove unused imports
simeongelovski Apr 8, 2026
6ab1d99
Review fixes
simeongelovski Apr 8, 2026
8aa2b18
Update pyproject.toml
simeongelovski Apr 8, 2026
06b0bd8
Review fixes
simeongelovski Apr 8, 2026
692e29c
Review fixes
simeongelovski Apr 8, 2026
ab1a919
Fix imports
simeongelovski Apr 8, 2026
7782615
Fix tests
simeongelovski Apr 8, 2026
4a1a8e9
Fix tests
simeongelovski Apr 8, 2026
3c89b52
Fix tests
simeongelovski Apr 8, 2026
6480135
Fix tests
simeongelovski Apr 8, 2026
29d2ec5
Fix tests
simeongelovski Apr 8, 2026
d27e299
Fix tests
simeongelovski Apr 8, 2026
469e0f8
Fix formating
simeongelovski Apr 9, 2026
2127ac2
Exclude code checks
simeongelovski Apr 9, 2026
a4fa77c
Fix code check
simeongelovski Apr 9, 2026
d85b624
Fix linter
simeongelovski Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix tests
  • Loading branch information
@simeongelovski
simeongelovski committed Apr 8, 2026
commit 3c89b52e0a60cad3f4143225c6c003cd535bb716
6 changes: 5 additions & 1 deletion tests/core/unit/telemetry/test_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,20 +12,23 @@ def test_module_values(self):
"""Test that Module enum has expected values."""
assert Module.AICORE.value == "aicore"
assert Module.AUDITLOG.value == "auditlog"
assert Module.AUDITLOG_NG.value == "auditlog_ng"
assert Module.DESTINATION.value == "destination"
assert Module.OBJECTSTORE.value == "objectstore"

def test_module_str_representation(self):
"""Test that Module enum converts to string correctly."""
assert str(Module.AICORE) == "aicore"
assert str(Module.AUDITLOG) == "auditlog"
assert str(Module.AUDITLOG_NG) == "auditlog_ng"
assert str(Module.DESTINATION) == "destination"
assert str(Module.OBJECTSTORE) == "objectstore"

def test_module_is_string_enum(self):
"""Test that Module enum inherits from str."""
assert isinstance(Module.AICORE, str)
assert isinstance(Module.AUDITLOG, str)
assert isinstance(Module.AUDITLOG_NG, str)
assert isinstance(Module.DESTINATION, str)

def test_module_equality(self):
Expand All @@ -44,7 +47,7 @@ def test_module_in_collection(self):
def test_all_modules_present(self):
"""Test that all expected modules are present."""
all_modules = list(Module)
assert len(all_modules) == 4
assert len(all_modules) == 5
assert Module.AICORE in all_modules
assert Module.AUDITLOG in all_modules
assert Module.DESTINATION in all_modules
Expand All @@ -55,5 +58,6 @@ def test_module_iteration(self):
module_values = [str(m) for m in Module]
assert "aicore" in module_values
assert "auditlog" in module_values
assert "auditlog_ng" in module_values
assert "destination" in module_values
assert "objectstore" in module_values
5 changes: 3 additions & 2 deletions tests/core/unit/telemetry/test_operation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ def test_auditlog_operations(self):
"""Test Audit Log operation values."""
assert Operation.AUDITLOG_LOG.value == "log"
assert Operation.AUDITLOG_LOG_BATCH.value == "log_batch"
assert Operation.AUDITLOG_CREATE_CLIENT.value == "create_client"

def test_destination_operations(self):
"""Test Destination operation values."""
Expand Down Expand Up @@ -105,5 +106,5 @@ def test_operation_iteration(self):
def test_operation_count(self):
"""Test that we have the expected number of operations."""
all_operations = list(Operation)
# 2 auditlog + 8 destination + 7 certificate + 7 fragment + 8 objectstore + 2 aicore = 34
assert len(all_operations) == 34
# 3 auditlog + 8 destination + 7 certificate + 7 fragment + 8 objectstore + 2 aicore = 34
assert len(all_operations) == 35
Loading