Skip to content

feat: Implement Auditlog NG client#41

Open
simeongelovski wants to merge 17 commits intoSAP:mainfrom
auditlog-service:auditlog-ng-impl
Open

feat: Implement Auditlog NG client#41
simeongelovski wants to merge 17 commits intoSAP:mainfrom
auditlog-service:auditlog-ng-impl

Conversation

@simeongelovski
Copy link
Copy Markdown
Member

No description provided.

@simeongelovski simeongelovski requested a review from a team as a code owner April 7, 2026 14:06
@cla-assistant
Copy link
Copy Markdown

cla-assistant bot commented Apr 7, 2026

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Copy Markdown
Member

@jeanscherf jeanscherf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gen/ directory contains generated *_pb2.py files but there are no .proto source files checked in. Without the sources no one can regenerate or update the generated code.

  • Add proto source files to src/sap_cloud_sdk/core/auditlog_ng/proto/ with a
    buf.yaml and buf.gen.yaml that configure output into gen/ and src/buf/.
    (really liked buf btw! Thanks for the suggestion!).

  • Also add a Makefile at the repo root with at minimum:

.PHONY: proto
proto:
    cd src/sap_cloud_sdk/core/auditlog_ng/proto && buf generate
  • Add .github/workflows/proto-verify.yml that runs
    make proto and then git diff --exit-code to fail the PR if generated files differ.

Let me know if you need any help with all that.

Co-authored-by: Jean Scherf <jeanscherf@gmail.com>
@simeongelovski simeongelovski changed the title Implement Auditlog NG client feat: Implement Auditlog NG client Apr 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants