Repository navigation
Avoid duplicate AST initialization and lazy-import locals allocation - #9183
Draft
youknowdot wants to merge 1 commit into
Draft
youknowdot wants to merge 1 commit into
youknowdot wants to merge 1 commit into
Conversation
Let type.__call__ own AST initialization, matching CPython generic allocation, and inspect existing frame locals without materializing them for lazy policy checks. Assisted-by: OpenAI Codex:model version unavailable
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up on the two review findings in #9179 after its merge.
PyType::callinvoke the AST initializer once.NodeAst::slot_newonly allocates, matching CPython'sPyType_GenericNew. This also preserves custom subclass initializers that deliberately omitsuper().__init__()and allocation-only direct__new__calls.__lazy_modules__lookup.Only two Rust files change. No library copies, test expectations, or skip markers change.
Validation
Fresh release binary built from this follow-up on main
9f6f7719.d220409: abstract warning count, inherited field writes, custom/delegating initialization, and direct__new__allocation.test_ast: 220 total, 205 pass, 9 skip, 6 existing expected failures.test_lazy_import: 161 total, 157 pass, 4 skip.-D warnings.The existing missing-C-API skips and AST expected failures remain visible; these results do not claim complete AST or compiler parity.