Skip to content

Fix deprecated PyO3 code input import in benchmarks - #9161

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:dot/fix-pyo3-code-input
Oct 16, 2026
Merged

Fix deprecated PyO3 code input import in benchmarks#9161
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:dot/fix-pyo3-code-input

Conversation

@youknowdot

@youknowdot youknowdot commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Use pyo3::types::code::PyCodeInput in the execution benchmark. PyO3 0.30 deprecated the root types alias, which fails main's all-target Clippy jobs under -D warnings.

No lint suppression or behavior change.

Validation

  • Normal repository pre-commit hooks passed (including rustfmt and cspell).
  • Confirmed the canonical path against PyO3 v0.30.1 source.
  • Passed full workspace/all-target Clippy with -D warnings (excluding the separately configured C-API crate, wasm, and Windows venvlauncher), resolving PyO3 0.30.1.
  • Workspace and C-API unit tests are not yet completed locally. Exact-head GitHub CI is running and will be tracked before this is considered ready.

AI disclosure

OpenAI Codex assisted with diagnosis, the one-line patch, validation, and this draft PR. Model version unavailable.

@youknowdot
Fix deprecated PyO3 code input import in benchmarks
bf076f1 
Use the canonical code module path introduced in PyO3 0.30 without suppressing deprecation warnings.

Assisted-by: OpenAI Codex:model version unavailable
@coderabbitai

coderabbitai Bot commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Configuration used: Repository: RustPython/RustPython/.coderabbit.yml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2ca31d00-3b67-454b-b262-5826914987bb
📥 Commits

Reviewing files that changed from the base of the PR and between fd5b30e and bf076f1.

📒 Files selected for processing: 1
  • benches/execution.rs
+--------------------------------------------------------------+
| Your function has more side effects than my caffeine intake. |
+--------------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

This was referenced Oct 16, 2026
Merged
Merged
@fanninpm

fanninpm commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

cc @bschoenmaeckers

@fanninpm
fanninpm requested a review from youknowone October 16, 2026 14:03
@fanninpm fanninpm mentioned this pull request Oct 16, 2026
Merged
@youknowone
youknowone marked this pull request as ready for review October 16, 2026 14:43
@youknowone
youknowone merged commit b2b865a into RustPython:main Oct 16, 2026
21 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T14:44:58.705450Z bf076f1 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes
+1 more reviewer
@bschoenmaeckers bschoenmaeckers bschoenmaeckers approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@youknowdot @fanninpm @youknowone @bschoenmaeckers