Align socket and socketserver with Python 3.15 final by youknowdot · Pull Request #9156 · RustPython/RustPython

youknowdot · 2026-10-15T14:06:21Z

Summary

Split the socket/socketserver portion of #8954 into five files, synchronized with CPython 3.15 final (d220409a13b77de7a6c30abe16ea90db01528edc).

Import the complete socket.py, socketserver.py, test_socket.py, and test_socketserver.py using the actual scripts/update_lib copy/migrate commands. Preserve all five existing AF_ALG expected-failure markers. No hand-edited library/test bodies, duplicate snippets, support-module changes, or workflows.
Match setsockopt positional parsing, index-before-buffer conversion, and error ordering. Python conversions, warnings, and buffer acquisition finish before the socket lock; the socket guard drops before the buffer export is released.
Correct final-CPython optlen semantics beyond the original mega patch: use the index protocol, mask to unsigned 32 bits, and issue DeprecationWarning("integer value out of range") outside [-2**31, 2**32 - 1]. Warning-as-error propagates before the third-argument shape check or host call.
Reject Windows buffer lengths above INT_MAX before the host call.
Preserve arbitrary-precision integer ports in getaddrinfo, accept index objects before string/bytes handling, and return an empty canonical name when the resolver supplies none.

Provenance and overlap

The three Python files other than test_socket.py match the pinned CPython blobs byte-for-byte. test_socket.py differs only by the five retained AF_ALG decorators.

The tested commit is retained rather than rebased over unrelated main changes. At publication, the main-relative PR patch still contains exactly the reviewed five files. #9143 remains open and adds an expected-failure marker to test_getaddrinfo_int_port_overflow; that marker must be preserved if integrated because this run did not execute the real _testcapi-dependent body. The older socket overlap in #8007 concerns separate SSL/wait gating.

Local validation

Normal commit hooks, the matching narrow release build, and strict stdlib/VM all-targets Clippy passed:

cargo build --release --offline --locked -p rustpython --bin rustpython -j1 \
  --no-default-features --features threading,stdlib,stdio,importlib,host_env

cargo clippy --release --offline --locked -p rustpython-stdlib -p rustpython-vm \
  --all-targets --no-default-features \
  --features rustpython-stdlib/compiler,rustpython-stdlib/host_env,rustpython-stdlib/threading,rustpython-vm/compiler,rustpython-vm/gc,rustpython-vm/host_env,rustpython-vm/stdio,rustpython-vm/importlib,rustpython-vm/encodings,rustpython-vm/threading \
  -- -D warnings

Eight unchanged canonical method extracts passed, each in a fresh bounded process:

test_socket.GeneralModuleTests: testDefaultTimeout, testGetSockOpt, testSetSockOpt, test_setsockopt_errors, test_SocketType_is_socketobject, and testNewAttributes
test_socketserver.TestModule.test_deprecated__version__
test_socketserver.MiscTestCase.test_all

Four temporary supplemental checks passed: numeric-only getaddrinfo index/type/boundary/canonical-name cases; setsockopt optlen warnings and error order; a tiny native AF_UNIX socketpair/sendfile check; and socketserver attributes without starting a server. Every giant-optlen check supplied a non-None third argument and was rejected before host access. The sendfile fixture was 32 bytes, with 50 bytes transferred across the bounded cases; no external DNS was used.

The additional canonical test_getaddrinfo_int_port_overflow naturally skipped because the real _testcapi module is absent. Its body remains untested; no fake module or constants were substituted.

The runtime used the original library inventory with source/module-origin checks and time, memory, output, descriptor, and process limits. Initial missing native-math/IDNA admission failures were preserved, then corrected only in separately reviewed temporary import allowlists. No repository behavior or test assertion was changed to clear those gates. Source hashes remained unchanged across build, Clippy, and runtime, and an independent review checked the selected result receipts.

This is bounded Linux coverage, not a full test_socket/test_socketserver or workspace-suite pass. Windows/macOS/BSD/WASI behavior, broad DNS/non-UTF8/SSL/AF_VSOCK parity, raw-device tests, and server/fork loops were not exercised. The Windows length guard was source-reviewed only.

Validation identities:

Commit: ed08422bea7d1483a9a5a615870b7339a5dcc76b
Five-file patch SHA-256: e4493b63070d4578a60c1893273c5f791108a34d76781827730604d17b7c9624
Tested binary SHA-256: d44bdf898535141ef097c856552d332f1478443f69f14e515dc7307e1d288316
Result manifest SHA-256: 9f31d781770839feaebe550240542bf4ac7d5f4f3d7e09f54c58b6977e0bf36d

AI assistance

OpenAI Codex assisted with the implementation, canonical-source synchronization, source review, bounded validation, and this description. The exact model version was unavailable; the commit includes an Assisted-by trailer.

Import the canonical socket libraries and tests through update_lib, preserving the existing AF_ALG expected failures. Match setsockopt index/buffer conversion and error ordering, mask optlen with the final CPython deprecation warning, reject oversized Windows buffers before the host call, and preserve arbitrary-precision getaddrinfo ports and empty canonical names. Assisted-by: OpenAI Codex:model version unavailable

coderabbitai · 2026-10-15T14:06:31Z

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration

Configuration used: Repository: RustPython/RustPython/.coderabbit.yml
Review profile: CHILL
Plan: Advanced
Run ID: 880326b1-7b7b-4d2d-bd54-e111e2644dae

📥 Commits

Reviewing files that changed from the base of the PR and between 8e5709e and ed08422.

⛔ Files ignored due to path filters: 4

Lib/socket.py is excluded by !Lib/**
Lib/socketserver.py is excluded by !Lib/**
Lib/test/test_socket.py is excluded by !Lib/**
Lib/test/test_socketserver.py is excluded by !Lib/**

📒 Files selected for processing: 1

crates/stdlib/src/socket.rs

+-----------------------------------------------------------+
| This loop is doing cardio. Your users are doing timeouts. |
+-----------------------------------------------------------+
  \
   \   (\__/)
       (•ㅅ•)
       / 　 づ

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create a new PR

Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-15T16:01:05Z

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

:4: SyntaxWarning: invalid decimal literal
:7: SyntaxWarning: "\z" is an invalid escape sequence. Such sequences will not work in the future. Did you mean "\z"? A raw string is also an option.
:10: SyntaxWarning: "\400" is an invalid octal escape sequence. Such sequences will not work in the future. Did you mean "\400"? A raw string is also an option.
:4: SyntaxWarning: invalid decimal literal
:7: SyntaxWarning: "\z" is an invalid escape sequence. Such sequences will not work in the future. Did you mean "\z"? A raw string is also an option.
:10: SyntaxWarning: "\400" is an invalid octal escape sequence. Such sequences will not work in the future. Did you mean "\400"? A raw string is also an option.
:4: SyntaxWarning: invalid decimal literal
:7: SyntaxWarning: "\z" is an invalid escape sequence. Such sequences will not work in the future. Did you mean "\z"? A raw string is also an option.
:10: SyntaxWarning: "\400" is an invalid octal escape sequence. Such sequences will not work in the future. Did you mean "\400"? A raw string is also an option.
[x] lib: cpython/Lib/socketserver.py
[x] test: cpython/Lib/test/test_socketserver.py

dependencies:

socketserver

dependent tests: (11 tests)

socketserver: test_imaplib test_logging test_socketserver test_wsgiref
- http.server: test_httpservers test_robotparser test_urllib2_localnet test_xmlrpc
  - pydoc: test_enum test_pydoc
  - xmlrpc.server: test_docxmlrpc

[ ] lib: cpython/Lib/threading.py
[ ] lib: cpython/Lib/_threading_local.py
[ ] test: cpython/Lib/test/test_threading.py (TODO: 6)
[x] test: cpython/Lib/test/test_threadedtempfile.py
[x] test: cpython/Lib/test/test_threading_local.py

dependencies:

threading (native: _collections, _contextvars, _thread, itertools, sys, time)
- _threading_local
- _threading_local
- collections (native: _collections, _weakref, itertools, sys)
- contextlib (native: sys)
- os (native: nt, os.path, posix, sys)
- traceback (native: _missing_stdlib_info, _suggestions, collections.abc, importlib.machinery, importlib.resources.readers, importlib.util, itertools, sys, unicodedata)
- weakref (native: _weakref, atexit, gc, itertools, sys)
- _weakrefset, functools, warnings

dependent tests: (168 tests)

[x] lib: cpython/Lib/socket.py
[x] test: cpython/Lib/test/test_socket.py (TODO: 5)

dependencies:

socket

dependent tests: (103 tests)

[ ] test: cpython/Lib/test/test_bytes.py (TODO: 15)

dependencies:

dependent tests: (no tests depend on bytes)

[x] test: cpython/Lib/test/test_thread.py (TODO: 1)
[ ] test: cpython/Lib/test/test_thread_local_bytecode.py
[x] test: cpython/Lib/test/test_threadsignals.py

dependencies:

dependent tests: (14 tests)
- [ ] concurrent.futures: test_asyncio test_compileall test_concurrent_futures test_context test_genericalias test_inspect test_struct test_wmi
- [ ] asyncio: test_asyncio test_external_inspection test_logging test_os test_pdb test_unittest

Legend:

[+] path exists in CPython
[x] up-to-date, [ ] outdated

chatgpt-codex-connector · 2026-10-16T01:15:00Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-16T01:21:17.467424Z	`ed08422`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ed08422bea

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-16T01:21:15Z

+        with socket_setdefaulttimeout(10.125):
+            self.assertEqual(socket.getdefaulttimeout(), 10.125)


Keep the timeout test body unchanged

Do not land this imported test-body change: it changes timeout test data and assertions, while the repository policy permits test-file edits only for adding or removing expected-failure decorators. Keep this test body unchanged and validate the new behavior without modifying Lib/test.

AGENTS.md reference: AGENTS.md:L278-L282

Useful? React with 👍 / 👎.

youknowone approved these changes Oct 16, 2026

View reviewed changes

youknowone marked this pull request as ready for review October 16, 2026 01:14

youknowone merged commit fd5b30e into RustPython:main Oct 16, 2026
31 checks passed

chatgpt-codex-connector Bot reviewed Oct 16, 2026

View reviewed changes

Navigation Menu

Repository navigation

Align socket and socketserver with Python 3.15 final - #9156

Align socket and socketserver with Python 3.15 final#9156
youknowone merged 1 commit into
RustPython:mainfrom
youknowdot:split/socket-315-final

youknowdot commented Oct 15, 2026

Uh oh!

coderabbitai Bot commented Oct 15, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 15, 2026

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 16, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Oct 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		with socket_setdefaulttimeout(10.125):
		self.assertEqual(socket.getdefaulttimeout(), 10.125)

Conversation

youknowdot commented Oct 15, 2026

Summary

Provenance and overlap

Local validation

AI assistance

Uh oh!

coderabbitai Bot commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 15, 2026

📦 Library Dependencies

Uh oh!

Uh oh!

chatgpt-codex-connector Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 16, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Oct 15, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 16, 2026 •

edited

Loading