Skip to content

Update malachite crates to 0.14.0 - #9117

Merged
youknowone merged 1 commit into
RustPython:mainfrom
youknowone:bump-malachite-0.14
Oct 14, 2026
Merged

youknowone merged 1 commit into
RustPython:mainfrom
youknowone:bump-malachite-0.14

Conversation

@youknowone

@youknowone youknowone commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

example_projects/frozen_stdlib has no lockfile, and pymath 0.2.0 requires malachite-bigint ^0, so the example now resolves malachite-bigint 0.14.0 while the workspace pins 0.13.0. The two BigInt types then mismatch and the "Run rust tests (ubuntu-latest)" job fails on main.

This bumps malachite-bigint, malachite-q and malachite-base to 0.14.0, as #9003 did for 0.13.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated the Malachite library dependencies to version 0.14.0.

pymath requires malachite-bigint ^0, so the example projects, which
have no lock file, resolve it to 0.14.0 while the workspace pinned
0.13.0, and fail to build.

Assisted-by: Claude Code:claude-opus-5-5
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-14T11:51:22.054021Z 16f1ebc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: RustPython/RustPython/.coderabbit.yml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5892fc3a-60db-403f-8164-c132304ec290
📥 Commits

Reviewing files that changed from the base of the PR and between bc8080a and 16f1ebc.

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing: 1
  • Cargo.toml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The workspace dependency versions for malachite-bigint, malachite-q, and malachite-base changed from 0.13.0 to 0.14.0.

Changes: Malachite dependency update

Layer / File(s) Summary
Update workspace dependency versions
Cargo.toml
The workspace versions of malachite-bigint, malachite-q, and malachite-base changed from 0.13.0 to 0.14.0.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Suggested reviewers: joshuamegnauth54

Merge Risk: ⚪ Minimal · up to 16f1e

The example inherits the updated dependency version, and the reported BigInt mismatch is not present in the inspected build path. No actionable merge risk remains from this issue.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: updating the Malachite crates to version 0.14.0.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 16f1ebc020

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread Cargo.toml
malachite-bigint = "0.13.0"
malachite-q = "0.13.0"
malachite-base = "0.13.0"
malachite-bigint = "0.14.0"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Add the required AI-assistance trailer

The commit message explicitly says the change was generated with Claude Code, but it contains only a Generated with footer rather than the required Assisted-by: AGENT_NAME:MODEL_VERSION trailer, so the AI assistance is not disclosed in the repository-mandated format. Add the required trailer before merging.

AGENTS.md reference: AGENTS.md:L23-L23

Useful? React with 👍 / 👎.

@youknowone
youknowone merged commit 0816af6 into RustPython:main Oct 14, 2026
9 checks passed
@youknowone
youknowone deleted the bump-malachite-0.14 branch October 14, 2026 11:54
@codspeed

codspeed Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 4 skipped benchmarks1


Comparing youknowone:bump-malachite-0.14 (16f1ebc) with main (28393e9)2

Open in CodSpeed

Footnotes

  1. 4 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (bc8080a) during the generation of this report, so 28393e9 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant