Skip to content

Skip flaky asyncio tests #8075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 2 commits into from
Jun 11, 2026
+2 −0
Merged

Skip flaky asyncio tests #8075

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74cb5a1
Skip flaky test on windows
ShaharNaveh Jun 11, 2026
e93afe3
Skip another flaky test
ShaharNaveh Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Lib/test/test_asyncio/test_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,6 +791,7 @@ def test_create_connection_local_addr(self):
self.assertEqual(port, expected)
tr.close()

@unittest.skipIf(sys.platform == "linux", "TODO: Flaky on CI")

@ShaharNaveh ShaharNaveh Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen at https://github.com/RustPython/RustPython/actions/runs/27331458747/job/80744671194?pr=8075

(this PR)

@fanninpm fanninpm Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@unittest.skipIf(sys.platform == "linux", "TODO: Flaky on CI")
@unittest.skipIf(sys.platform == "linux", "TODO: RUSTPYTHON, Flaky on CI")

@ShaharNaveh ShaharNaveh Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks!

@socket_helper.skip_if_tcp_blackhole
def test_create_connection_local_addr_skip_different_family(self):
# See https://github.com/python/cpython/issues/86508
Expand Down
1 change: 1 addition & 0 deletions Lib/test/test_asyncio/test_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,6 +628,7 @@ def kill():
self.assertTrue(killed)
test_utils.run_briefly(self.loop)

@unittest.skipIf(sys.platform == "win32", "TODO: RUSTPYTHON; Flaky on CI")
def test_close_dont_kill_finished(self):

async def kill_running():
Expand Down
Loading