Skip to content

Skip flaky asyncio tests#8075

Merged
youknowone merged 2 commits into
RustPython:mainfrom
ShaharNaveh:skip-flakey-windows-test-async
Jun 11, 2026
Merged

Skip flaky asyncio tests#8075
youknowone merged 2 commits into
RustPython:mainfrom
ShaharNaveh:skip-flakey-windows-test-async

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@coderabbitai

coderabbitai Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (2)
  • Lib/test/test_asyncio/test_events.py is excluded by !Lib/**
  • Lib/test/test_asyncio/test_subprocess.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 7db40b14-89a7-4e9c-a7fb-756ada593a59

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📦 Library Dependencies

The following Lib/ modules were modified. Here are their dependencies:

[x] lib: cpython/Lib/asyncio
[ ] test: cpython/Lib/test/test_asyncio (TODO: 34)

dependencies:

  • asyncio

dependent tests: (6 tests)

  • asyncio: test_asyncio test_inspect test_logging test_os test_pdb test_unittest

Legend:

  • [+] path exists in CPython
  • [x] up-to-date, [ ] outdated

@ShaharNaveh ShaharNaveh changed the title Skip flaky test on windows Skip flaky asyncio tests Jun 11, 2026
ShaharNaveh
ShaharNaveh commented Jun 11, 2026
View reviewed changes
Comment thread Lib/test/test_asyncio/test_events.py
self.assertEqual(port, expected)
tr.close()

@unittest.skipIf(sys.platform == "linux", "TODO: Flaky on CI")

@ShaharNaveh ShaharNaveh Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen at https://github.com/RustPython/RustPython/actions/runs/27331458747/job/80744671194?pr=8075

(this PR)

@fanninpm fanninpm Jun 11, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@unittest.skipIf(sys.platform == "linux", "TODO: Flaky on CI")
@unittest.skipIf(sys.platform == "linux", "TODO: RUSTPYTHON, Flaky on CI")

@ShaharNaveh ShaharNaveh Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, thanks!

@youknowone youknowone merged commit 65dee6c into RustPython:main Jun 11, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fanninpm fanninpm fanninpm left review comments

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShaharNaveh @youknowone @fanninpm