Macro for defining opcode & instruction enums#7573
Macro for defining opcode & instruction enums#7573ShaharNaveh wants to merge 3 commits intoRustPython:mainfrom
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| } | ||
|
|
||
| #[derive(Clone, Copy, Debug)] | ||
| #[repr($typ)] |
There was a problem hiding this comment.
I wanted to remove this #[repr(...)], but when doing so I get the following error:
thread 'main' (3429) panicked at crates/vm/src/frame.rs:3790:33: index out of bounds: the len is 5 but the index is 22
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
RustPython/crates/vm/src/frame.rs
Lines 3787 to 3791 in d5a90e5
This macro will generate an
Instructionand aOpcodeenum, all within rust, no external python scripts with custom config in toml or something.I'd love to hear what you guys think:)