const Opcode.name() method

ShaharNaveh · ShaharNaveh · commit 93c38d8f96ea · 2026-04-15T09:57:45.000+02:00
diff --git a/crates/compiler-core/src/bytecode/instruction.rs b/crates/compiler-core/src/bytecode/instruction.rs
@@ -33,13 +33,20 @@ macro_rules! define_opcodes {
 
         impl $opcode_name {
             #[must_use]
-            pub const fn as_instruction(&self) -> $instr_name {
+            $opcode_vis const fn as_instruction(&self) -> $instr_name {
                 match self {
                     $(
                         Self::$op_name => $instr_name::$op_name $({ $arg_name: Arg::marker() })?,
                     )*
                 }
             }
+
+            #[must_use]
+            $opcode_vis const fn name(&self) -> &str {
+                match self {
+                    $(Self::$op_name => $op_display,)*
+                }
+            }
         }
 
         impl From<$opcode_name> for $instr_name {
@@ -70,9 +77,7 @@ macro_rules! define_opcodes {
 
         impl ::core::fmt::Display for $opcode_name {
             fn fmt(&self, f: &mut ::core::fmt::Formatter<'_>) -> ::core::fmt::Result {
-                match self {
-                    $(Self::$op_name => write!(f, $op_display),)*
-                }
+                write!(f, "{}", self.name())
             }
         }
 
@@ -87,7 +92,7 @@ macro_rules! define_opcodes {
 
         impl $instr_name {
             #[must_use]
-            pub const fn opcode(&self) -> $opcode_name {
+            $instr_vis const fn opcode(&self) -> $opcode_name {
                 match self {
                     $(
                         Self::$op_name $({ $arg_name: _ })? => $opcode_name::$op_name,
