Fix del obj.dict to match CPython behavior (fixes #5355)#7568

Merged

youknowone merged 23 commits intoRustPython:mainfrom

alok-108:fix-issue-5355-del-dict

Apr 30, 2026

Commits on Apr 30, 2026

Fix del obj.__dict__ to match CPython behavior (issue #5355)

alok-108
authored and
youknowone
committed
Address CodeRabbit concerns: fix GC clearing and improve thread safety of lazy __dict__ recreation

alok-108
authored and
youknowone
committed
Fix del obj.__dict__: improve GC safety, implement lazy re-creation in setattr, and enable passing CPython tests

alok-108
authored and
youknowone
committed
Restore expectedFailure for test_has_inline_values

alok-108
authored and
youknowone
committed
Fix ObjExt::new call site to include has_dict parameter

alok-108
authored and
youknowone
committed
Remove stray test.py to avoid CI syntax errors

alok-108
authored and
youknowone
committed
Remove debug txt files and clean test_class.py comments

alok-108
authored and
youknowone
committed
Delete Lib/test/test_class.py

alok-108
authored and
youknowone
committed
Restore test_class.py with correct changes (remove expectedFailure, no deletion)

alok-108
authored and
youknowone
committed
Fix clippy warnings: remove unused into_inner, collapse nested if-let

alok-108
authored and
youknowone
committed
Fix rustfmt formatting and ruff PEP 8 E302 blank line

alok-108
authored and
youknowone
committed
Align __dict__ error messages and ensure safety for function/partial objects

alok-108
authored and
youknowone
committed
Fix compilation errors: change &self to &Py<Self> in __dict__ methods

alok-108
authored and
youknowone
committed
Fix compilation errors: resolve borrow-after-move and replace transpose on PySetterValue

alok-108
authored and
youknowone
committed
Fix compilation errors: resolve borrow-after-move and replace transpose on PySetterValue

alok-108
authored and
youknowone
committed
Fix snippet formatting and mark test_remote as expected failure

alok-108
authored and
youknowone
committed
Fix test_remote by removing HAS_DICT flag from function type

alok-108
authored and
youknowone
committed
Fix lint formatting error

alok-108
authored and
youknowone
committed
Remove unnecessary print statement in test_del_dict

alok-108
authored and
youknowone
committed
Fix trailing newlines in snippet test

alok-108
authored and
youknowone
committed
Trigger CI

alok-108
authored and
youknowone
committed
Align __dict__ generic setter behavior
youknowone
committed
Move __dict__ deletion tests to relevant snippets
youknowone
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix del obj.dict to match CPython behavior (fixes #5355)#7568

Fix del obj.dict to match CPython behavior (fixes #5355)#7568
youknowone merged 23 commits intoRustPython:mainfrom
alok-108:fix-issue-5355-del-dict

Commits on Apr 30, 2026

Fix del obj.dict to match CPython behavior (issue #5355)

Address CodeRabbit concerns: fix GC clearing and improve thread safety of lazy dict recreation

Fix del obj.dict: improve GC safety, implement lazy re-creation in setattr, and enable passing CPython tests

Restore expectedFailure for test_has_inline_values

Fix ObjExt::new call site to include has_dict parameter

Remove stray test.py to avoid CI syntax errors

Remove debug txt files and clean test_class.py comments

Delete Lib/test/test_class.py

Restore test_class.py with correct changes (remove expectedFailure, no deletion)

Fix clippy warnings: remove unused into_inner, collapse nested if-let

Fix rustfmt formatting and ruff PEP 8 E302 blank line

Align dict error messages and ensure safety for function/partial objects

Fix compilation errors: change &self to &Py<Self> in dict methods

Fix compilation errors: resolve borrow-after-move and replace transpose on PySetterValue

Fix compilation errors: resolve borrow-after-move and replace transpose on PySetterValue

Fix snippet formatting and mark test_remote as expected failure

Fix test_remote by removing HAS_DICT flag from function type

Fix lint formatting error

Remove unnecessary print statement in test_del_dict

Fix trailing newlines in snippet test

Trigger CI

Align dict generic setter behavior

Move dict deletion tests to relevant snippets