-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix del obj.__dict__ to match CPython behavior (fixes #5355) #7568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alok-108
wants to merge
13
commits into
RustPython:main
Choose a base branch
from
alok-108:fix-issue-5355-del-dict
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
f1d9358
Fix del obj.__dict__ to match CPython behavior (issue #5355)
alok-108 28c5fe2
Address CodeRabbit concerns: fix GC clearing and improve thread safet…
alok-108 d3cc9d4
Fix del obj.__dict__: improve GC safety, implement lazy re-creation i…
alok-108 0b085ee
Restore expectedFailure for test_has_inline_values
alok-108 477c901
Fix ObjExt::new call site to include has_dict parameter
alok-108 4cc6d83
Remove stray test.py to avoid CI syntax errors
alok-108 f7f9e28
Remove debug txt files and clean test_class.py comments
alok-108 6ca9631
Delete Lib/test/test_class.py
alok-108 2564ed1
Restore test_class.py with correct changes (remove expectedFailure, n…
alok-108 7651712
Fix clippy warnings: remove unused into_inner, collapse nested if-let
alok-108 7882153
Fix rustfmt formatting and ruff PEP 8 E302 blank line
alok-108 143a92c
Align __dict__ error messages and ensure safety for function/partial …
alok-108 c46e482
Fix compilation errors: change &self to &Py<Self> in __dict__ methods
alok-108 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # Test that del obj.__dict__ works and lazy creation happens | ||
| class C: | ||
| pass | ||
|
|
||
|
|
||
| obj = C() | ||
| obj.x = 42 | ||
|
|
||
| # Delete __dict__ | ||
| del obj.__dict__ | ||
|
|
||
| # After deletion, accessing __dict__ should return a new empty dict | ||
| d = obj.__dict__ | ||
| assert isinstance(d, dict) | ||
| assert len(d) == 0 | ||
|
|
||
| # Old attribute should be gone | ||
| try: | ||
| obj.x | ||
| assert False, "AttributeError expected" | ||
| except AttributeError: | ||
| pass | ||
|
|
||
| # Function __dict__ deletion should fail | ||
| def f(): pass | ||
| try: | ||
| del f.__dict__ | ||
| assert False, "TypeError expected for function dict deletion" | ||
| except TypeError: | ||
| pass | ||
|
|
||
| # functools.partial __dict__ deletion should fail | ||
| import functools | ||
| p = functools.partial(f) | ||
| try: | ||
| del p.__dict__ | ||
| assert False, "TypeError expected for partial dict deletion" | ||
| except TypeError: | ||
| pass | ||
|
|
||
| print("OK") |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.