Skip to content

Preserve str subclass results from __repr__ in plain str() #7454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
+30 −7
Draft

Preserve str subclass results from __repr__ in plain str() #7454

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a56d78
Initial plan
Copilot Mar 17, 2026
ed2fd1e
Preserve str subclass returned by __repr__
Copilot Mar 17, 2026
2ff66e7
Format str constructor fast path
Copilot Mar 17, 2026
5140534
Tighten str subclass conversion regression
Copilot Mar 17, 2026
9a11d44
Align test_str with CPython and move local coverage
Copilot Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Preserve str subclass returned by __repr__ 
Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>
  • Loading branch information
@youknowone
Copilot and youknowone committed Mar 28, 2026
commit ed2fd1e16fcd2bc6e61fc2289c46d1eb0ad773b4
1 change: 0 additions & 1 deletion Lib/test/test_str.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2414,7 +2414,6 @@ def test_ucs4(self):
else:
self.fail("Should have raised UnicodeDecodeError")

@unittest.expectedFailure # TODO: RUSTPYTHON; AssertionError: <class 'str'> is not <class 'test.test_str.StrSubclass'>
def test_conversion(self):
# Make sure __str__() works properly
class StrWithStr(str):
Expand Down
5 changes: 2 additions & 3 deletions crates/vm/src/builtins/str.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,13 +394,12 @@ impl Constructor for PyStr {
type Args = StrArgs;

fn slot_new(cls: PyTypeRef, func_args: FuncArgs, vm: &VirtualMachine) -> PyResult {
// Optimization: return exact str as-is (only when no encoding/errors provided)
// Optimization: for exact str, return PyObject_Str result as-is
if cls.is(vm.ctx.types.str_type)
&& func_args.args.len() == 1
&& func_args.kwargs.is_empty()
Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot Mar 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[auto-format] reported by reviewdog 🐶

Suggested change
if cls.is(vm.ctx.types.str_type)
&& func_args.args.len() == 1
&& func_args.kwargs.is_empty()
if cls.is(vm.ctx.types.str_type) && func_args.args.len() == 1 && func_args.kwargs.is_empty()

&& func_args.args[0].class().is(vm.ctx.types.str_type)
{
return Ok(func_args.args[0].clone());
return func_args.args[0].str(vm).map(Into::into);
}

let args: Self::Args = func_args.bind(vm)?;
Expand Down