Skip to content

Preserve str subclass results from __repr__ in plain str() #7454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 5 commits into
base: main
Choose a base branch
from
+30 −7
Draft

Preserve str subclass results from __repr__ in plain str() #7454

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8a56d78
Initial plan
Copilot Mar 17, 2026
ed2fd1e
Preserve str subclass returned by __repr__
Copilot Mar 17, 2026
2ff66e7
Format str constructor fast path
Copilot Mar 17, 2026
5140534
Tighten str subclass conversion regression
Copilot Mar 17, 2026
9a11d44
Align test_str with CPython and move local coverage
Copilot Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Format str constructor fast path 
Co-authored-by: youknowone <69878+youknowone@users.noreply.github.com>
  • Loading branch information
@youknowone
Copilot and youknowone committed Mar 28, 2026
commit 2ff66e7ed74145e8f3fd85de2f4bab2d0a29abb8
4 changes: 1 addition & 3 deletions crates/vm/src/builtins/str.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,9 +395,7 @@ impl Constructor for PyStr {

fn slot_new(cls: PyTypeRef, func_args: FuncArgs, vm: &VirtualMachine) -> PyResult {
// Optimization: for exact str, return PyObject_Str result as-is
if cls.is(vm.ctx.types.str_type)
&& func_args.args.len() == 1
&& func_args.kwargs.is_empty()
if cls.is(vm.ctx.types.str_type) && func_args.args.len() == 1 && func_args.kwargs.is_empty()
{
return func_args.args[0].str(vm).map(Into::into);
}
Expand Down