Skip to content

Add freelists for PyComplex, PyInt, PyRange #7345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 6 commits into from
Mar 5, 2026
Merged

Add freelists for PyComplex, PyInt, PyRange #7345

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d3cc53a
Add freelists for PyComplex, PyInt, PyBoundMethod, PyRange
youknowone Mar 4, 2026
3d4951d
Use alloc::dealloc in FreeList::Drop to avoid thread-local access panic
youknowone Mar 4, 2026
7b25894
Auto-format: cargo fmt --all
github-actions[bot] Mar 4, 2026
b962909
Fix clippy: use core::alloc::Layout instead of alloc::alloc::Layout
youknowone Mar 4, 2026
7b614ae
Address review: PyBoundMethod clear=false, update FreeList doc comment
youknowone Mar 4, 2026
01b5319
Remove PyBoundMethod freelist to fix refcount/weakref test failures
youknowone Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review: PyBoundMethod clear=false, update FreeList doc comment 
- Set clear=false on PyBoundMethod (tp_clear=NULL in classobject.c)
- Update FreeList doc comment to match actual Drop behavior (raw dealloc)
  • Loading branch information
@youknowone
youknowone committed Mar 4, 2026
commit 7b614aef3c2e101f0e032c8153e2abb806a89e25
2 changes: 1 addition & 1 deletion crates/vm/src/builtins/function.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1084,7 +1084,7 @@ impl Constructor for PyFunction {
}
}

#[pyclass(module = false, name = "method", traverse)]
#[pyclass(module = false, name = "method", traverse, clear = false)]
#[derive(Debug)]
pub struct PyBoundMethod {
object: PyObjectRef,
Expand Down
8 changes: 4 additions & 4 deletions crates/vm/src/object/core.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -858,11 +858,11 @@ impl<T: PyPayload + core::fmt::Debug> PyInner<T> {
}
}

/// Thread-local freelist storage that properly deallocates cached objects
/// on thread teardown.
/// Thread-local freelist storage for reusing object allocations.
///
/// Wraps a `Vec<*mut PyObject>` and implements `Drop` to convert each
/// raw pointer back into `Box<PyInner<T>>` for proper deallocation.
/// Wraps a `Vec<*mut PyObject>`. On thread teardown, `Drop` frees raw
/// `PyInner<T>` allocations without running payload destructors to avoid
/// accessing already-destroyed thread-local storage (GC state, other freelists).
pub(crate) struct FreeList<T: PyPayload> {
items: Vec<*mut PyObject>,
_marker: core::marker::PhantomData<T>,
Expand Down