Skip to content

Add freelists for PyComplex, PyInt, PyRange #7345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 6 commits into from
Mar 5, 2026
Merged

Add freelists for PyComplex, PyInt, PyRange #7345

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d3cc53a
Add freelists for PyComplex, PyInt, PyBoundMethod, PyRange
youknowone Mar 4, 2026
3d4951d
Use alloc::dealloc in FreeList::Drop to avoid thread-local access panic
youknowone Mar 4, 2026
7b25894
Auto-format: cargo fmt --all
github-actions[bot] Mar 4, 2026
b962909
Fix clippy: use core::alloc::Layout instead of alloc::alloc::Layout
youknowone Mar 4, 2026
7b614ae
Address review: PyBoundMethod clear=false, update FreeList doc comment
youknowone Mar 4, 2026
01b5319
Remove PyBoundMethod freelist to fix refcount/weakref test failures
youknowone Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use alloc::dealloc in FreeList::Drop to avoid thread-local access panic 
During thread teardown, Box::from_raw triggers cascading destructors
that may access already-destroyed thread-local storage (GC state, other
freelists). Use raw dealloc instead to free memory without running
destructors.
  • Loading branch information
@youknowone
youknowone committed Mar 4, 2026
commit 3d4951d2dbc0d1f5646283dce59c9f2b5c5bfba4
13 changes: 12 additions & 1 deletion crates/vm/src/object/core.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,8 +885,19 @@ impl<T: PyPayload> Default for FreeList<T> {

impl<T: PyPayload> Drop for FreeList<T> {
fn drop(&mut self) {
// During thread teardown, we cannot safely run destructors on cached
// objects because their Drop impls may access thread-local storage
// (GC state, other freelists) that is already destroyed.
// Instead, free just the raw allocation. The payload's heap fields
// (BigInt, PyObjectRef, etc.) are leaked, but this is bounded by
// MAX_FREELIST per type per thread.
for ptr in self.items.drain(..) {
drop(unsafe { Box::from_raw(ptr as *mut PyInner<T>) });
unsafe {
alloc::alloc::dealloc(
ptr as *mut u8,
alloc::alloc::Layout::new::<PyInner<T>>(),
);
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.
}
}
}
Expand Down