Skip to content

[update_lib] show dependent tests in deps subcommand #6828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 17 commits into from
Jan 22, 2026
Merged

[update_lib] show dependent tests in deps subcommand #6828

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4154c5e
Show affected tests for given module names
moreal Jan 21, 2026
923ed8e
Support --exclude option to deps subcommand to exclude dependencies
moreal Jan 21, 2026
4c116cd
Exclude non-test files from deps subcommand impact output
moreal Jan 21, 2026
62b9d4e
Recursively search test module directories for deps impact
moreal Jan 21, 2026
774451a
Revert --exclude option of deps subcommand
moreal Jan 21, 2026
e4acc38
Consolidate test module directories in deps impact output
moreal Jan 21, 2026
bf9d248
Add --impact-only flag to deps subcommand for test runner integration
moreal Jan 21, 2026
f7e08cf
Rename impact to dependent tests and make it default in deps subcommand
moreal Jan 21, 2026
38af152
Auto-format: ruff format
github-actions[bot] Jan 21, 2026
682212e
Refactor
moreal Jan 21, 2026
e4bf543
pick a useful level
youknowone Jan 22, 2026
1cb5cc9
Auto-format: ruff format
github-actions[bot] Jan 22, 2026
124ca34
Auto-format: ruff check --select I --fix
github-actions[bot] Jan 22, 2026
3b782b8
sync marker
youknowone Jan 22, 2026
6c44b6c
ci test in rust test
youknowone Jan 22, 2026
184abf1
remove unused
youknowone Jan 22, 2026
39cabdd
Auto-format: ruff format
github-actions[bot] Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor
  • Loading branch information
@moreal @youknowone
moreal authored and youknowone committed Jan 22, 2026
commit 682212eb64b7ca1cfdb823dc6205215998edf9bc
17 changes: 7 additions & 10 deletions scripts/update_lib/deps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,10 @@
- Test dependencies (auto-detected from 'from test import ...')
"""

import ast
import functools
import pathlib
from collections import deque

from update_lib.io_utils import read_python_files, safe_parse_ast, safe_read_text
from update_lib.path import construct_lib_path, resolve_module_path
Expand Down Expand Up @@ -226,8 +228,6 @@ def parse_test_imports(content: str) -> set[str]:
Returns:
Set of module names imported from test package
"""
import ast

tree = safe_parse_ast(content)
if tree is None:
return set()
Expand Down Expand Up @@ -262,8 +262,6 @@ def parse_lib_imports(content: str) -> set[str]:
Returns:
Set of imported module names (top-level only)
"""
import ast

tree = safe_parse_ast(content)
if tree is None:
return set()
Expand Down Expand Up @@ -506,6 +504,7 @@ def resolve_all_paths(
return result


@functools.cache
def _build_import_graph(lib_prefix: str = "Lib") -> dict[str, set[str]]:
"""Build a graph of module imports from lib_prefix directory.

Expand Down Expand Up @@ -585,10 +584,10 @@ def get_transitive_imports(

# BFS from module_name following reverse edges
visited: set[str] = set()
queue = list(reverse_graph.get(module_name, set()))
queue = deque(reverse_graph.get(module_name, set()))

while queue:
current = queue.pop(0)
current = queue.popleft()
if current in visited:
continue
visited.add(current)
Expand All @@ -609,8 +608,6 @@ def _parse_test_submodule_imports(content: str) -> dict[str, set[str]]:
Returns:
Dict mapping submodule (e.g., "test_bar") -> set of imported names (e.g., {"helper"})
"""
import ast

tree = safe_parse_ast(content)
if tree is None:
return {}
Expand Down Expand Up @@ -730,9 +727,9 @@ def find_tests_importing_module(
# Second pass: find files that transitively import via support files within test/
# BFS to find all files that import any file in all_importing
all_importing = set(directly_importing)
queue = list(directly_importing)
queue = deque(directly_importing)
while queue:
current = queue.pop(0)
current = queue.popleft()
# Extract the filename (stem) from the relative path for matching
current_path = pathlib.Path(current)
current_stem = current_path.name
Expand Down