Skip to content

[update_lib] show dependent tests in deps subcommand #6828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 17 commits into from
Jan 22, 2026
Merged

[update_lib] show dependent tests in deps subcommand #6828

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
4154c5e
Show affected tests for given module names
moreal Jan 21, 2026
923ed8e
Support --exclude option to deps subcommand to exclude dependencies
moreal Jan 21, 2026
4c116cd
Exclude non-test files from deps subcommand impact output
moreal Jan 21, 2026
62b9d4e
Recursively search test module directories for deps impact
moreal Jan 21, 2026
774451a
Revert --exclude option of deps subcommand
moreal Jan 21, 2026
e4acc38
Consolidate test module directories in deps impact output
moreal Jan 21, 2026
bf9d248
Add --impact-only flag to deps subcommand for test runner integration
moreal Jan 21, 2026
f7e08cf
Rename impact to dependent tests and make it default in deps subcommand
moreal Jan 21, 2026
38af152
Auto-format: ruff format
github-actions[bot] Jan 21, 2026
682212e
Refactor
moreal Jan 21, 2026
e4bf543
pick a useful level
youknowone Jan 22, 2026
1cb5cc9
Auto-format: ruff format
github-actions[bot] Jan 22, 2026
124ca34
Auto-format: ruff check --select I --fix
github-actions[bot] Jan 22, 2026
3b782b8
sync marker
youknowone Jan 22, 2026
6c44b6c
ci test in rust test
youknowone Jan 22, 2026
184abf1
remove unused
youknowone Jan 22, 2026
39cabdd
Auto-format: ruff format
github-actions[bot] Jan 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Auto-format: ruff format
  • Loading branch information
@github-actions @youknowone
github-actions[bot] authored and youknowone committed Jan 22, 2026
commit 38af152dcc4f961e1fb97b1fb62a7de6d6e35fd8
12 changes: 7 additions & 5 deletions scripts/update_lib/show_deps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,7 +202,9 @@ def format_deps(
consolidated = consolidate_test_paths(impacted_tests, test_dir)

if consolidated:
lines.append(f"[+] dependent tests: ({len(consolidated)} tests depend on {name})")
lines.append(
f"[+] dependent tests: ({len(consolidated)} tests depend on {name})"
)
for test_name in sorted(consolidated):
lines.append(f" - {test_name}")
else:
Expand Down Expand Up @@ -250,9 +252,7 @@ def show_deps(
for i, name in enumerate(expanded_names):
if i > 0:
print() # blank line between modules
for line in format_deps(
name, cpython_prefix, lib_prefix, max_depth, visited
):
for line in format_deps(name, cpython_prefix, lib_prefix, max_depth, visited):
print(line)


Expand Down Expand Up @@ -291,7 +291,9 @@ def main(argv: list[str] | None = None) -> int:
args = parser.parse_args(argv)

try:
show_deps(args.names, args.cpython, args.lib, args.depth, args.dependent_tests_only)
show_deps(
args.names, args.cpython, args.lib, args.depth, args.dependent_tests_only
)
return 0
except Exception as e:
print(f"Error: {e}", file=sys.stderr)
Expand Down
16 changes: 10 additions & 6 deletions scripts/update_lib/tests/test_deps.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,7 +764,9 @@ def test_module_directory_tests_consolidated(self):
(module_dir / "test_backup.py").write_text("# test")

result = consolidate_test_paths(
frozenset({module_dir / "test_dbapi.py", module_dir / "test_backup.py"}),
frozenset(
{module_dir / "test_dbapi.py", module_dir / "test_backup.py"}
),
test_dir,
)
self.assertEqual(result, frozenset({"test_sqlite3"}))
Expand All @@ -782,11 +784,13 @@ def test_mixed_top_level_and_module_directory(self):
(module_dir / "test_backup.py").write_text("# test")

result = consolidate_test_paths(
frozenset({
test_dir / "test_foo.py",
module_dir / "test_dbapi.py",
module_dir / "test_backup.py",
}),
frozenset(
{
test_dir / "test_foo.py",
module_dir / "test_dbapi.py",
module_dir / "test_backup.py",
}
),
test_dir,
)
self.assertEqual(result, frozenset({"test_foo", "test_sqlite3"}))
Expand Down