Skip to content

Support pickle better with __getnewargs_ex__ #6749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 6 commits into from
Jan 17, 2026
Merged

Support pickle better with __getnewargs_ex__ #6749

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9efc8d1
Implement pickle more
youknowone Jan 16, 2026
9720798
unmark succesful tests
youknowone Jan 16, 2026
3277a4d
add weakref check
youknowone Jan 16, 2026
1fc57af
check exports in __setstate__
youknowone Jan 16, 2026
4eb7828
remove reducelib
youknowone Jan 16, 2026
a418c68
unmark more tests
youknowone Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
unmark more tests
  • Loading branch information
@youknowone
youknowone committed Jan 16, 2026
commit a418c68fa0018c97efd38104a02e9fb5396d2080
8 changes: 0 additions & 8 deletions Lib/test/test_pickletools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,15 +97,7 @@ def test_oob_buffers(self): # TODO(RUSTPYTHON): Remove this test when it passes
def test_oob_buffers_writable_to_readonly(self): # TODO(RUSTPYTHON): Remove this test when it passes
return super().test_oob_buffers_writable_to_readonly()

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_py_methods(self): # TODO(RUSTPYTHON): Remove this test when it passes
return super().test_py_methods()

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_complex_newobj_ex(self): # TODO(RUSTPYTHON): Remove this test when it passes
return super().test_complex_newobj_ex()

# TODO: RUSTPYTHON
@unittest.expectedFailure
Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10328,7 +10328,6 @@ def test_special_attrs(self):

TypeName = typing.NewType('SpecialAttrsTests.TypeName', Any)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_special_attrs2(self):
# Forward refs provide a different introspection API. __name__ and
# __qualname__ make little sense for forward refs as they can store
Expand Down
1 change: 0 additions & 1 deletion Lib/test/test_unittest/test_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1297,7 +1297,6 @@ def _makeResult(self):
expected = ['startTestRun', 'stopTestRun']
self.assertEqual(events, expected)

@unittest.expectedFailure # TODO: RUSTPYTHON
def test_pickle_unpickle(self):
# Issue #7197: a TextTestRunner should be (un)pickleable. This is
# required by test_multiprocessing under Windows (in verbose mode).
Expand Down
6 changes: 0 additions & 6 deletions Lib/test/test_zlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,15 +747,11 @@ def test_baddecompresscopy(self):
self.assertRaises(ValueError, copy.copy, d)
self.assertRaises(ValueError, copy.deepcopy, d)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_compresspickle(self):
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
with self.assertRaises((TypeError, pickle.PicklingError)):
pickle.dumps(zlib.compressobj(zlib.Z_BEST_COMPRESSION), proto)

# TODO: RUSTPYTHON
@unittest.expectedFailure
def test_decompresspickle(self):
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
with self.assertRaises((TypeError, pickle.PicklingError)):
Expand Down Expand Up @@ -1006,8 +1002,6 @@ def testDecompress4G(self, size):
compressed = None
decompressed = None

# TODO: RUSTPYTHON
@unittest.expectedFailure
def testPickle(self):
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
with self.assertRaises(TypeError):
Expand Down