Skip to content

Support pickle better with __getnewargs_ex__ #6749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 6 commits into from
Jan 17, 2026
Merged

Support pickle better with __getnewargs_ex__ #6749

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9efc8d1
Implement pickle more
youknowone Jan 16, 2026
9720798
unmark succesful tests
youknowone Jan 16, 2026
3277a4d
add weakref check
youknowone Jan 16, 2026
1fc57af
check exports in __setstate__
youknowone Jan 16, 2026
4eb7828
remove reducelib
youknowone Jan 16, 2026
a418c68
unmark more tests
youknowone Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add weakref check
  • Loading branch information
@youknowone
youknowone committed Jan 16, 2026
commit 3277a4db8be7a9de28907fe2c27b74a8e665bc20
14 changes: 14 additions & 0 deletions crates/vm/src/builtins/object.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,20 @@ fn object_getstate_default(obj: &PyObject, required: bool, vm: &VirtualMachine)
basicsize += core::mem::size_of::<PyObjectRef>();
}

// Add __weakref__ size if type has weakref support
let has_weakref = if let Some(ref ext) = obj.class().heaptype_ext {
match &ext.slots {
None => true, // Heap type without __slots__ has automatic weakref
Some(slots) => slots.iter().any(|s| s.as_str() == "__weakref__"),
}
} else {
let weakref_name = vm.ctx.intern_str("__weakref__");
obj.class().attributes.read().contains_key(weakref_name)
};
if has_weakref {
basicsize += core::mem::size_of::<PyObjectRef>();
}

// Add slots size
if let Some(ref slot_names) = slot_names {
basicsize += core::mem::size_of::<PyObjectRef>() * slot_names.__len__();
Expand Down