Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed failing tests
  • Loading branch information
terryluan12 authored and youknowone committed Jan 15, 2026
commit 59b0be2344c2666a3b0df02d8a65d340265483e3
1 change: 1 addition & 0 deletions Lib/test/test_class.py
Original file line number Diff line number Diff line change
Expand Up @@ -978,6 +978,7 @@ class Bar: pass
self.assertIsInstance(f, Bar)
self.assertEqual(f.__dict__, {})

@unittest.skip("TODO: RUSTPYTHON, unexpectedly long runtime")
def test_store_attr_type_cache(self):
"""Verifies that the type cache doesn't provide a value which is
inconsistent from the dict."""
Expand Down
3 changes: 2 additions & 1 deletion Lib/test/test_descr.py
Original file line number Diff line number Diff line change
Expand Up @@ -1834,7 +1834,8 @@ def __init__(self, foo):
object.__init__(A(3))
self.assertRaises(TypeError, object.__init__, A(3), 5)

@unittest.expectedFailure
# TODO: RUSTPYTHON; The `expectedFailure` here is from CPython, so this test actually fails. Not run on linux?
# @unittest.expectedFailure
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@youknowone what do you want to do about this? Related: python/cpython#49572

Copy link
Copy Markdown
Member

@youknowone youknowone Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found our __new__ behavior is different from Python 3.14. (not checked incompatibility of 3.13 or changed in 3.14)
Let's see that change affect this change

def test_restored_object_new(self):
class A(object):
def __new__(cls, *args, **kwargs):
Expand Down
11 changes: 11 additions & 0 deletions Lib/test/test_ftplib.py
Original file line number Diff line number Diff line change
Expand Up @@ -919,6 +919,17 @@ def setUp(self, encoding=DEFAULT_ENCODING):
self.client.auth()
self.client.prot_p()

@unittest.expectedFailureIfWindows #TODO: RUSTPYTHON; Not run on linux? Okay on mac
def test_encoding_param(self):
super().test_encoding_param()

@unittest.expectedFailureIfWindows #TODO: RUSTPYTHON; Not run on linux? Okay on mac
def test_storbinary(self):
super().test_storbinary()

@unittest.expectedFailureIfWindows #TODO: RUSTPYTHON; Not run on linux? Okay on mac
def test_storbinary_rest(self):
super().test_storbinary_rest()

@skipUnless(ssl, "SSL not available")
@requires_subprocess()
Expand Down
1 change: 1 addition & 0 deletions Lib/test/test_importlib/test_threaded_import.py
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,7 @@ def test_concurrent_futures_circular_import(self):
'partial', 'cfimport.py')
script_helper.assert_python_ok(fn)

@unittest.expectedFailureIfWindows # TODO: RUSTPYTHON; AttributeError: module '_winapi' has no attribute 'NMPWAIT_WAIT_FOREVER - Not run on linux?
def test_multiprocessing_pool_circular_import(self):
# Regression test for bpo-41567
fn = os.path.join(os.path.dirname(__file__),
Expand Down
7 changes: 7 additions & 0 deletions Lib/test/test_socket.py
Original file line number Diff line number Diff line change
Expand Up @@ -6844,6 +6844,13 @@ class SendfileUsingSendfileTest(SendfileUsingSendTest):
def meth_from_sock(self, sock):
return getattr(sock, "_sendfile_use_sendfile")

@unittest.expectedFailure #TODO: RUSTPYTHON; Not run on linux?
def testWithTimeout(self):
super().testWithTimeout()

@unittest.expectedFailure #TODO: RUSTPYTHON; Not run on linux?
def testCount(self):
super().testCount()

@unittest.skipUnless(HAVE_SOCKET_ALG, 'AF_ALG required')
class LinuxKernelCryptoAPI(unittest.TestCase):
Expand Down
1 change: 1 addition & 0 deletions Lib/test/test_sort.py
Original file line number Diff line number Diff line change
Expand Up @@ -132,6 +132,7 @@ def bad_key(x):

class TestBugs(unittest.TestCase):

@unittest.skip("TODO: RUSTPYTHON; figure out how to detect sort mutation that doesn't change list length; Only run on linux?")
def test_bug453523(self):
# bug 453523 -- list.sort() crasher.
# If this fails, the most likely outcome is a core dump.
Expand Down
1 change: 1 addition & 0 deletions Lib/test/test_sqlite3/test_regression.py
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,7 @@ def test_recursive_cursor_init(self):
self.assertRaisesRegex(sqlite.ProgrammingError, self.msg,
self.cur.fetchall)

@unittest.skip("TODO: RUSTPYTHON; Hangs; Not run on linux?")
def test_recursive_cursor_close(self):
conv = lambda x: self.cur.close()
with patch.dict(sqlite.converters, {"CLOSE": conv}):
Expand Down
1 change: 1 addition & 0 deletions Lib/test/test_ssl.py
Original file line number Diff line number Diff line change
Expand Up @@ -4596,6 +4596,7 @@ def server_callback(identity):
with client_context.wrap_socket(socket.socket()) as s:
s.connect((HOST, server.port))

@unittest.expectedFailure("TODO: RUSTPYTHON; Not run on linux?")
def test_thread_recv_while_main_thread_sends(self):
# GH-137583: Locking was added to calls to send() and recv() on SSL
# socket objects. This seemed fine at the surface level because those
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_subprocess.py
Original file line number Diff line number Diff line change
Expand Up @@ -2318,7 +2318,7 @@ def _test_extra_groups_impl(self, *, gid, group_list):
extra_groups=[name_group])

# No skip necessary, this test won't make it to a setgroup() call.
@unittest.expectedFailure # TODO: RUSTPYTHON
@unittest.skip('TODO: RUSTPYTHON; Not run on linux?')
def test_extra_groups_invalid_gid_t_values(self):
with self.assertRaises(ValueError):
subprocess.check_call(ZERO_RETURN_CMD, extra_groups=[-1])
Expand Down
2 changes: 1 addition & 1 deletion Lib/test/test_tempfile.py
Original file line number Diff line number Diff line change
Expand Up @@ -1735,7 +1735,7 @@ def test_cleanup_with_symlink_to_a_directory(self):
d2.cleanup()

@os_helper.skip_unless_symlink
@unittest.expectedFailure # TODO: RUSTPYTHON
@unittest.expectedFailureIf(sys.platform != "darwin", "TODO: RUSTPYTHON; Not run in linux? Passes on Mac")
def test_cleanup_with_symlink_modes(self):
# cleanup() should not follow symlinks when fixing mode bits (#91133)
with self.do_create(recurse=0) as d2:
Expand Down