Skip to content

Downgraded skips in tests #6716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
youknowone merged 13 commits into from
Jan 15, 2026
Merged

Downgraded skips in tests #6716

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4e658db
Downgraded skips in tests
terryluan12 Jan 12, 2026
59b0be2
Fixed failing tests
terryluan12 Jan 13, 2026
6c3ee49
Fixed test_ftplib + test_socket + test_ssl + test_threaded_import fai…
terryluan12 Jan 13, 2026
55665b7
Removed comments about which tests are run in which environment
terryluan12 Jan 13, 2026
4c1dd38
Addressed PR comments
terryluan12 Jan 13, 2026
87fa39d
Annotated skips on failing tests
terryluan12 Jan 13, 2026
e0fa426
Removed unneeded tests
terryluan12 Jan 13, 2026
46677e7
Removed unneeded sys import from test_ftplib
terryluan12 Jan 13, 2026
96daa90
Added annotation to test_ftplib
terryluan12 Jan 13, 2026
4f86cbf
Readded skipIf to test_cleanup_with_symlink_modes with a more general…
terryluan12 Jan 14, 2026
d5035f4
Addressed PR comments
terryluan12 Jan 14, 2026
6a3932d
Made changes to minimize diff in PR
terryluan12 Jan 14, 2026
6b57027
Apply suggestion from @youknowone
youknowone Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Readded skipIf to test_cleanup_with_symlink_modes with a more general… 
… ENV_POLLUTING_TESTS_WINDOWS
  • Loading branch information
@terryluan12 @youknowone
terryluan12 authored and youknowone committed Jan 15, 2026
commit 4f86cbf661c2f4e8aa09cacfb3c0e3b04045a8f8
1 change: 1 addition & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@ env:
test.test_multiprocessing_forkserver.test_processes
test.test_multiprocessing_spawn.test_processes
ENV_POLLUTING_TESTS_WINDOWS: >-
test.test_tempfile
# Python version targeted by the CI.
PYTHON_VERSION: "3.13.1"
X86_64_PC_WINDOWS_MSVC_OPENSSL_LIB_DIR: C:\Program Files\OpenSSL\lib\VC\x64\MD
Expand Down
5 changes: 4 additions & 1 deletion Lib/test/test_tempfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1735,7 +1735,10 @@ def test_cleanup_with_symlink_to_a_directory(self):
d2.cleanup()

@os_helper.skip_unless_symlink
@unittest.skip('TODO: RUSTPYTHON; alters the execution environment (env changed)')
@unittest.skipIf(
sys.platform == 'win32' and 'RUSTPYTHON_SKIP_ENV_POLLUTERS' in os.environ,
'TODO: RUSTPYTHON; alters the execution environment (env changed)'
)
def test_cleanup_with_symlink_modes(self):
# cleanup() should not follow symlinks when fixing mode bits (#91133)
with self.do_create(recurse=0) as d2:
Expand Down