Skip to content

Fully implement buffered IO#2323

Merged
coolreader18 merged 20 commits into
masterfrom
coolreader18/buffer-io
Nov 7, 2020
Merged

Fully implement buffered IO#2323
coolreader18 merged 20 commits into
masterfrom
coolreader18/buffer-io

Conversation

@coolreader18
Copy link
Copy Markdown
Member

Hoo boy, this took a while

@coolreader18 coolreader18 force-pushed the coolreader18/buffer-io branch 2 times, most recently from d218b46 to 7e1f389 Compare November 6, 2020 18:51
@coolreader18 coolreader18 force-pushed the coolreader18/buffer-io branch from 4e0cf5d to 955f961 Compare November 6, 2020 21:42
@coolreader18 coolreader18 force-pushed the coolreader18/buffer-io branch from 955f961 to 916bb4c Compare November 6, 2020 23:37
@coolreader18
Copy link
Copy Markdown
Member Author

I think the issue with windows file stuff (here and with test_importlib) is that we don't use _wopen, we std's OpenOptions, which uses a winapi function. Maybe there is some way to fix the permissions while using OpenOptions, but I'm not sure what it is.

@coolreader18 coolreader18 force-pushed the coolreader18/buffer-io branch from 759fa63 to 9433126 Compare November 7, 2020 20:55
@coolreader18 coolreader18 merged commit 17e0e75 into master Nov 7, 2020
@coolreader18 coolreader18 deleted the coolreader18/buffer-io branch November 7, 2020 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants