Try fix os.open on windows ci

coolreader18 · coolreader18 · commit 759fa6311ab9 · 2020-11-06T22:35:49.000-06:00
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -123,7 +123,7 @@ jobs:
             test_argparse test_json test_bytes test_long test_pwd test_bool test_cgi test_complex
             test_exception_hierarchy test_glob test_iter test_list test_os test_pathlib
             test_py_compile test_set test_shutil test_sys test_unicode test_unittest test_venv
-            test_zipimport test_importlib test_io
+            test_zipimport test_importlib
         env:
           RUSTPYTHONPATH: ${{ github.workspace }}/Lib
         if: runner.os == 'Windows'
diff --git a/vm/src/stdlib/os.rs b/vm/src/stdlib/os.rs
@@ -353,10 +353,10 @@ mod _os {
             }
         }
 
-        #[cfg(windows)]
-        let flags = flags & !(libc::O_WRONLY as u32);
+        // #[cfg(windows)]
+        // let flags = flags & !(libc::O_WRONLY as u32);
 
-        #[cfg(not(target_os = "wasi"))]
+        #[cfg(unix)]
         {
             use platform::OpenOptionsExt;
             options.custom_flags(flags);

Original file line number	Diff line number	Diff line change
`@@ -353,10 +353,10 @@ mod _os {`
`353`	`353`	`}`
`354`	`354`	`}`
`355`	`355`
`356`		`- #[cfg(windows)]`
`357`		`- let flags = flags & !(libc::O_WRONLY as u32);`
	`356`	`+ // #[cfg(windows)]`
	`357`	`+ // let flags = flags & !(libc::O_WRONLY as u32);`
`358`	`358`
`359`		`- #[cfg(not(target_os = "wasi"))]`
	`359`	`+ #[cfg(unix)]`
`360`	`360`	`{`
`361`	`361`	`use platform::OpenOptionsExt;`
`362`	`362`	`options.custom_flags(flags);`