Skip to content

Revert "install-powershell.sh: Adding autodetection of curl / wget" due to regression#7918

Merged
TravisEz13 merged 1 commit into
masterfrom
revert-7893-install-powershell-add-curl-wget-detection-issue-7872
Oct 2, 2018
Merged

Revert "install-powershell.sh: Adding autodetection of curl / wget" due to regression#7918
TravisEz13 merged 1 commit into
masterfrom
revert-7893-install-powershell-add-curl-wget-detection-issue-7872

Conversation

@TravisEz13
Copy link
Copy Markdown
Member

@DarwinJS
Copy link
Copy Markdown
Contributor

DarwinJS commented Oct 2, 2018

Ok I fixed the indenting which shows a couple badly closed if statements. What is next - can you cancel this revert?

@TravisEz13 TravisEz13 merged commit cd18af0 into master Oct 2, 2018
@TravisEz13 TravisEz13 deleted the revert-7893-install-powershell-add-curl-wget-detection-issue-7872 branch October 2, 2018 01:52
@TravisEz13
Copy link
Copy Markdown
Member Author

@DarwinJS Can you open a new PR?

@TravisEz13
Copy link
Copy Markdown
Member Author

@SteveL-MSFT Perhaps we should move these to a separate repo? PowerShell-Tools and then we could add a CI system to verify these scripts work at least on a couple of OSs.

@SteveL-MSFT
Copy link
Copy Markdown
Member

@TravisEz13 I don't think it's worth the effort of a new repo just for a few tools. It would be better to have some tests for these tools since people are depending on them.

adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants