Skip to content

install-powershell.sh: Adding autodetection of curl / wget#7893

Merged
TravisEz13 merged 2 commits into
PowerShell:masterfrom
DarwinJS:install-powershell-add-curl-wget-detection-issue-7872
Oct 1, 2018
Merged

install-powershell.sh: Adding autodetection of curl / wget#7893
TravisEz13 merged 2 commits into
PowerShell:masterfrom
DarwinJS:install-powershell-add-curl-wget-detection-issue-7872

Conversation

@DarwinJS
Copy link
Copy Markdown
Contributor

PR Summary

install-powershell.sh now autodetects whether curl or wget is installed to download secondary script when it is not found locally.

PR Checklist

bash <(wget -qO- $gitreposcriptroot/appimage.sh) $@
fi
echo "Pulling and executing it from \"$gitreposcriptroot/appimage.sh\""
if [ -n "$(command -v curl)" ]; then
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how universal is command -v?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a discussion of it's portability versus other methods: https://stackoverflow.com/questions/592620/how-to-check-if-a-program-exists-from-a-bash-script

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@TravisEz13 TravisEz13 merged commit 4831a9f into PowerShell:master Oct 1, 2018
TravisEz13 added a commit that referenced this pull request Oct 2, 2018
TravisEz13 added a commit that referenced this pull request Oct 2, 2018
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019
…l#7893)

install-powershell.sh now autodetects whether curl or wget is installed to download secondary script when it is not found locally.
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants