Skip to content

Fix the hang issue in Travis CI build triggered by the [Feature] tag - #4536

Merged
Aditya Patwardhan (adityapatwardhan) merged 3 commits into
PowerShell:masterfrom
daxian-dbw:hangtest
Aug 9, 2017
Merged

Fix the hang issue in Travis CI build triggered by the [Feature] tag#4536
Aditya Patwardhan (adityapatwardhan) merged 3 commits into
PowerShell:masterfrom
daxian-dbw:hangtest

Conversation

@daxian-dbw

Copy link
Copy Markdown
Member

Some class related parser tests may cause Travis build to hang if they are running with CrossGen'ed assemblies. This is an issue to the CrossGen utility, and it's tracked by https://github.com/dotnet/coreclr/issues/9745.

To work around the issue, we made the following changes to our build:

  1. For pull request and push commit, build without '-CrossGen' and run the parsing tests
  2. For daily build, build with '-CrossGen' but don't run the parsing tests

The recent [Feature] tag support allows us to run the full build in PR or Commit-Push CI builds. The parser tests should run in those [Feature] tag builds, so we need to make sure the [Feature] tag builds don't use -CrossGen before running the tests.

Two other changes:

  1. Skip inheritance tests during daily build.
  2. Update badge only in daily build.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daxian-dbw

Copy link
Copy Markdown
Member Author

The failures in AppVeyor are all *-PSSessionConfiguration related, not caused by this PR.

@adityapatwardhan
Aditya Patwardhan (adityapatwardhan) merged commit 5d53bd3 into PowerShell:master Aug 9, 2017
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the hangtest branch August 9, 2017 22:02
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
…owerShell#4536)

* Fix the hang issue in Travis CI build triggered by the [Feature] tag

* [Feature] Update badge only in daily build

* [Feature] Use the term 'daily build'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants