Only push to NuGet for Full Build (cron) - #4517
Conversation
Aditya Patwardhan (adityapatwardhan)
left a comment
There was a problem hiding this comment.
I found another issue, we seem to be updating the badge on full build, including the one with [Feature]. We need a way to identify a CRON build and then do nuget publish and badge update.
There was a problem hiding this comment.
Typo in allready -> already
There was a problem hiding this comment.
This also published if it is [Feature] run?
There was a problem hiding this comment.
Only if we merge a feature... that is equivalent to a daily build, I'm fine with it. If it's a PR, it won't publish. And if you squash merge, you will likely, remove the [Feature] from the commit message.
There was a problem hiding this comment.
actually, a true merge would change the description of the last commit message too. Only merging to master using the rebase option would have this possible effect.
|
The badge issue is being fixed in #4536 |
There was a problem hiding this comment.
After merging a PR to master, if the commit message happen to have [Feature] tag, we will publish the nuget package as well. Is that desired? Maybe we should use $isDailyBuild instead.
There was a problem hiding this comment.
Rebased, and updated.
8afb947 to
b4bcbf1
Compare
Aditya Patwardhan (adityapatwardhan)
left a comment
There was a problem hiding this comment.
LGTM
Currently, every merge is also publishing.