Add description of recommended settings for VS Code - #4054
Conversation
8f2e798 to
bc5d3da
Compare
|
CI OSX temporary failed |
|
|
||
| By using the steps in the previous paragraph you can add onfiguration settings in `settings.json`. | ||
|
|
||
| We recommend the following configuration settings for Visual Studio Code: |
There was a problem hiding this comment.
Looks like a double space between following and configuration
| "editor.renderWhitespace": "all", | ||
| "editor.renderControlCharacters": true, | ||
| "omnisharp.projectLoadTimeout": 120, | ||
| "files.trimTrailingWhitespace": true |
There was a problem hiding this comment.
should we just limit this to resx and powershell script files for now or are all the c# files clean?
There was a problem hiding this comment.
C# files was fixed in #3001 by lzybkr.
But we stiil have about 350 files with tabs.
|
|
||
| ### Code Editors | ||
|
|
||
| [You can use multiplatform Visual Studio Code (VS Code)][use-vscode-editor] |
There was a problem hiding this comment.
I think it should say: You should use the multi-platform ...
And make just the Visual Studio Code (VSCode) the hyperlink instead of the whole line
|
Keith Hill (@rkeithhill) Any thoughts? |
|
Ilya (@iSazonov) The problem with putting this in the docs is that few people read the docs. That said, it's better to have in the docs than nowhere. :-) But at some point, I suggest we either add a This brings me to my next suggestion. Consider adding a |
|
Keith Hill (@rkeithhill) Thanks for great feedback! I think we should be more conservative - other developers might have their preferences and we shouldn't overwrite them. |
|
Keep in mind that the use of a "workspace" specific settings file only overrides "user" specific settings for that workspace. And that is typically what you want. That is, a user might prefer tabs to spaces but this project uses spaces. So adding that setting to an editor config file will ensure that spaces are used for this user in only this workspace. In his own projects, tabs will still be used. |
|
Keith Hill (@rkeithhill) The PR is for docs only. I believe your suggestions is great for new PR. Could you please open it? |
This reverts commit 84d458b.
No description provided.