Skip to content

Resx - remove trailing white spaces and extra Newline at EOF - #4047

Merged
Jason Shirk (lzybkr) merged 2 commits into
PowerShell:masterfrom
iSazonov:resx-ws
Jun 22, 2017
Merged

Resx - remove trailing white spaces and extra Newline at EOF#4047
Jason Shirk (lzybkr) merged 2 commits into
PowerShell:masterfrom
iSazonov:resx-ws

Conversation

@iSazonov

Copy link
Copy Markdown
Collaborator
  1. Commit - remove trailing white spaces

Motivation - So far we have not been able to use VS Code automatic removing trailing white spaces without the cleanup.

The cleanup is done with Jason Shirk (@lzybkr) script from #3001

  1. Commit - remove extra Newline at EOF

A few days ago in #3576 I saw Resx files without Newline at EOF. Now they're miraculously gone. I don't know who and how to fix it. Now I only found files with extra Newline at EOF. Fixing script is based on script above and attached.

fix_EOF.txt

@SteveL-MSFT Steve Lee (SteveL-MSFT) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update https://github.com/PowerShell/PowerShell/blob/master/docs/FAQ.md with the recommended settings in VSCode for automatic removing of trailing whitespace for resx files

@lzybkr

Copy link
Copy Markdown
Contributor

Just confirming - this PR does not leave files with no newlines at the EOF, right?
It just replaces 2 newlines with 1, or adds 1 if there was none, right?

@iSazonov

Copy link
Copy Markdown
Collaborator Author

Just confirming - this PR does not leave files with no newlines at the EOF, right?

Yes.

Just confirming - this PR does not leave files with no newlines at the EOF, right?

Yes. Actually only removes extra Newline at EOF. Resx files without Newline at EOF is not found.

@iSazonov

Copy link
Copy Markdown
Collaborator Author

@SteveL-MSFT

Copy link
Copy Markdown
Member

Ilya (@iSazonov) yeah, even better!

@iSazonov

Ilya (iSazonov) commented Jun 20, 2017

Copy link
Copy Markdown
Collaborator Author

Steve Lee (@SteveL-MSFT) I open #4054

Full description of VS Code is in using-vscode.md - so I added recommendations in the document and link from CONTRIBUTING.md

@lzybkr
Jason Shirk (lzybkr) merged commit aa97fe7 into PowerShell:master Jun 22, 2017
@iSazonov
Ilya (iSazonov) deleted the resx-ws branch June 23, 2017 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants