Skip to content

Add composed Spring annotations support#1090

Merged
velo merged 2 commits into
OpenFeign:masterfrom
beargummy:master
Oct 4, 2019
Merged

Add composed Spring annotations support#1090
velo merged 2 commits into
OpenFeign:masterfrom
beargummy:master

Conversation

@beargummy

Copy link
Copy Markdown
Contributor

Add Spring's composed annotations support (like @GetMapping). These are convenience methods that are quite frequently used.

Changeset might look a bit repetitive, however, to process annotations differently it would require bigger refactoring which is not intended by this minor auxiliary PR. As was mentioned in #1069, worse case this entire spring4 support can be deleted later.

@velo velo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition, thank you for that

Comment thread spring4/src/main/java/feign/spring/SpringContract.java Outdated
@velo velo added enhancement For recommending new capabilities ready to merge Will be merged if no other member ask for changes labels Oct 4, 2019
@velo velo merged commit 2dbe24a into OpenFeign:master Oct 4, 2019
velo pushed a commit that referenced this pull request Oct 7, 2024
* Add composed Spring annotations support
velo pushed a commit that referenced this pull request Oct 8, 2024
* Add composed Spring annotations support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement For recommending new capabilities ready to merge Will be merged if no other member ask for changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants