Spring4 contract#1069
Merged
Merged
Conversation
Member
Author
|
I will merge as is so I can cut a release with final set of changes to contract. Worse case scenario I can deleted spring4 support later. |
velo
added a commit
that referenced
this pull request
Oct 7, 2024
* Move DeclarativeContract to new file * Get spring4 contract to compile with feign10 * Move to declarative contract * Brought spring 4 contract back to life * Remove old badges * Throw error when contract mark a method as ignored
velo
added a commit
that referenced
this pull request
Oct 8, 2024
* Move DeclarativeContract to new file * Get spring4 contract to compile with feign10 * Move to declarative contract * Brought spring 4 contract back to life * Remove old badges * Throw error when contract mark a method as ignored
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanna test the declarative contract a bit further, and decide to bring an old project for spring 4 contracts under feign umbrella.
https://github.com/velo/feign-spring
This is does not replace/compete with
spring-cloud-openfeignas it only works with older versions of spring.