Expose itemIdGenerator that can be used to generate unique ID for items on ListView#4964
Conversation
…legating the creating of a unique id for an item to a consumer of the listview (NativeScript#4962)
|
Can anyone review that change? |
|
Can one of the admins verify this patch? |
9 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Hey @buuhuu, thank you for contribution, we are about to run some tests and will write you back soon. |
|
run ci |
|
run uitests |
|
I don't see the details of the test failures. Any insights? |
|
Hey @buuhuu, all tests are all right so far, thank you for your contribution. We will review this item soon and write you back. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Following the principle of the
itemTemplateSelector, I added anitemIdGeneratorfunction that defaults to simply returning the index of the item (this is the current behaviour of the Adapter implementation for android).Users can set the
itemIdGeneratorto return any number as unique id for the given item (index and items). In my project I use a hash function to generate that number from a unique string property.#4729 #4962 #4724