Skip to content

Expose itemIdGenerator that can be used to generate unique ID for items on ListView #4964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hshristov merged 2 commits into from
Dec 5, 2017
Merged

Expose itemIdGenerator that can be used to generate unique ID for items on ListView #4964

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f96a046
fixed the context of the getItem() call in android's ListView adapter…
Oct 18, 2017
9c75e3a
added itemIdGenerator function to the list-view interface to allow de…
Oct 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tns-core-modules/ui/list-view/list-view-common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,9 @@ export abstract class ListViewBase extends View implements ListViewDefinition {
public static itemTapEvent = "itemTap";
public static loadMoreItemsEvent = "loadMoreItems";
// TODO: get rid of such hacks.
public static knownFunctions = ["itemTemplateSelector"]; //See component-builder.ts isKnownFunction
public static knownFunctions = ["itemTemplateSelector", "itemIdGenerator"]; //See component-builder.ts isKnownFunction

private _itemIdGenerator: (item: any, index: number, items: any) => number = (_item: any, index: number) => index;
private _itemTemplateSelector: (item: any, index: number, items: any) => string;
private _itemTemplateSelectorBindable = new Label();
public _defaultTemplate: KeyedTemplate = {
Expand Down Expand Up @@ -72,6 +73,14 @@ export abstract class ListViewBase extends View implements ListViewDefinition {
}
}

get itemIdGenerator(): (item: any, index: number, items: any) => number {
return this._itemIdGenerator;
}

set itemIdGenerator(generatorFn: (item: any, index: number, items: any) => number) {
this._itemIdGenerator = generatorFn;
}

public refresh() {
//
}
Expand Down
9 changes: 7 additions & 2 deletions tns-core-modules/ui/list-view/list-view.android.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,14 +216,19 @@ function ensureListViewAdapterClass() {
public getItem(i: number) {
if (this.owner && this.owner.items && i < this.owner.items.length) {
let getItem = (<ItemsSource>this.owner.items).getItem;
return getItem ? getItem(i) : this.owner.items[i];
return getItem ? getItem.call(this.owner.items, i) : this.owner.items[i];
}

return null;
}

public getItemId(i: number) {
return long(i);
let item = this.getItem(i);
let id = i;
if (this.owner && item && this.owner.items) {
id = this.owner.itemIdGenerator(item, i, this.owner.items);
}
return long(id);
}

public hasStableIds(): boolean {
Expand Down
5 changes: 5 additions & 0 deletions tns-core-modules/ui/list-view/list-view.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,11 @@ export class ListView extends View {
*/
itemTemplateSelector: string | ((item: any, index: number, items: any) => string);

/**
* Item id generator
*/
itemIdGenerator: (item: any, index: number, items: any) => number;

/**
* Gets or set the items separator line color of the ListView.
*/
Expand Down