Skip to content

fix: improve view teardown process for reusable views #11260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edusperoni wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −2
Open

fix: improve view teardown process for reusable views #11260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions packages/core/ui/core/view-base/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1264,7 +1264,7 @@ export abstract class ViewBase extends Observable {
*/
public destroyNode(forceDestroyChildren?: boolean): void {
this.reusable = false;
this.callUnloaded();
this.unloadView(this);
this._tearDownUI(forceDestroyChildren);
}

Expand All @@ -1284,7 +1284,9 @@ export abstract class ViewBase extends Observable {

if (!preserveNativeView) {
this.eachChild((child) => {
child._tearDownUI(force);
// if we decided to tear down the current view, we should also tear down the children, even if they are reusable
// the developer is responsible to detach them if they need to reuse them somewhere else
child._tearDownUI(true);

return true;
});
Expand Down
Loading