fix: improve view teardown process for reusable views#11260
Open
edusperoni wants to merge 1 commit into
Open
Conversation
|
View your CI Pipeline Execution ↗ for commit 134c9e5
☁️ Nx Cloud last updated this comment at |
Collaborator
|
@edusperoni |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
When destroying a reusable view's node, two issues exist:
destroyNode()callscallUnloaded()unconditionally, even when the view was never loaded. This can fireunloadedlifecycle events (and run unload logic) on views that are not in a loaded state._tearDownUI(), children are torn down by inheriting the parent'sforceflag (child._tearDownUI(force)). When the parent is being destroyed but a child is marked asreusable, the child's native view is preserved and skipped, leaving orphaned/leaked native views behind.What is the new behavior?
destroyNode()now usesunloadView(this), which guards onview.isLoadedbefore callingcallUnloaded(), so the unloaded path only runs for views that are actually loaded.force = true(child._tearDownUI(true)), regardless of whether they are marked reusable. Once a parent is being destroyed, its children are destroyed too. Developers who want to reuse a child elsewhere are responsible for detaching it beforehand.Together these changes make the teardown process for reusable views more correct and prevent native view leaks.