Skip to content

fix(application): restore AndroidApplication.on etc. #10336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rigor789 merged 1 commit into from
Jul 10, 2023
Merged

fix(application): restore AndroidApplication.on etc. #10336

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions packages/core/application/application-common.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,28 @@ export class ApplicationCommon {
readonly loadAppCssEvent = 'loadAppCss';
readonly cssChangedEvent = 'cssChanged';

// Expose statically for backwards compat on AndroidApplication.on etc.
/**
* @deprecated Use `Application.android.on()` instead.
*/
static on: ApplicationEvents['on'] = globalEvents.on.bind(globalEvents);
/**
* @deprecated Use `Application.android.once()` instead.
*/
static once: ApplicationEvents['on'] = globalEvents.once.bind(globalEvents);
/**
* @deprecated Use `Application.android.off()` instead.
*/
static off: ApplicationEvents['off'] = globalEvents.off.bind(globalEvents);
/**
* @deprecated Use `Application.android.notify()` instead.
*/
static notify: ApplicationEvents['notify'] = globalEvents.notify.bind(globalEvents);
/**
* @deprecated Use `Application.android.hasListeners()` instead.
*/
static hasListeners: ApplicationEvents['hasListeners'] = globalEvents.hasListeners.bind(globalEvents);

// Application events go through the global events.
on: ApplicationEvents['on'] = globalEvents.on.bind(globalEvents);
once: ApplicationEvents['on'] = globalEvents.once.bind(globalEvents);
Expand Down