Skip to content

fix(application): restore AndroidApplication.on etc.#10336

Merged
rigor789 merged 1 commit intomainfrom
fix/android-application-listeners
Jul 10, 2023
Merged

fix(application): restore AndroidApplication.on etc.#10336
rigor789 merged 1 commit intomainfrom
fix/android-application-listeners

Conversation

@rigor789
Copy link
Copy Markdown
Member

@rigor789 rigor789 commented Jul 6, 2023

PR Checklist

What is the current behavior?

#10286 didn't account for usage of the AndroidApplication in the following scenario:

AndroidApplication.on(AndroidApplication.activityCreatedEvent, () => {});

What is the new behavior?

These are now exposed statically on the AndroidApplication to restore/remove the breaking change.

They are marked as deprecated as the preferred way to write these would be:

Application.android.on(Application.android.activityCreatedEvent, () => {});

to simplify usage/code across the board.

@cla-bot cla-bot bot added the cla: yes label Jul 6, 2023
@rigor789 rigor789 marked this pull request as ready for review July 6, 2023 14:56
@rigor789 rigor789 merged commit 0804934 into main Jul 10, 2023
@rigor789 rigor789 deleted the fix/android-application-listeners branch July 10, 2023 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant