Skip to content

Rename ROS 2 publisher to node#374

Merged
sgrizan-nv merged 1 commit intomainfrom
sgrizan/branch2
Apr 9, 2026
Merged

Rename ROS 2 publisher to node#374
sgrizan-nv merged 1 commit intomainfrom
sgrizan/branch2

Conversation

@sgrizan-nv
Copy link
Copy Markdown
Collaborator

@sgrizan-nv sgrizan-nv commented Apr 8, 2026 •
edited by coderabbitai Bot
Loading

It encapsulates a ROS 2 node, not a publisher.
A publisher in ROS 2 is an entity that publishes an individual topic.

Summary by CodeRabbit

  • Chores

    • Rebranded the teleop node from teleop_ros2_publisher to teleop_ros2_node across all configurations and documentation.

  • Documentation

    • Updated ROS 2 CLI command examples to reflect the new node name.

@sgrizan-nv
Rename ROS 2 publisher to node
6244352 
It encapsulates a ROS 2 node, not a publisher.
A publisher in ROS 2 is an entity that publishes an individual topic.
@sgrizan-nv sgrizan-nv self-assigned this Apr 8, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 8, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 81128d23-68ac-44c0-917a-4469351e55c4

📥 Commits

Reviewing files that changed from the base of the PR and between f420f71 and 6244352.

📒 Files selected for processing (4)
  • .github/workflows/build-ubuntu.yml
  • examples/teleop_ros2/Dockerfile
  • examples/teleop_ros2/README.md
  • examples/teleop_ros2/python/teleop_ros2_node.py
📝 Walkthrough

Walkthrough

This pull request renames the teleop node from teleop_ros2_publisher to teleop_ros2_node across four files. The Python class is renamed from TeleopRos2PublisherNode to TeleopRos2Node, with corresponding updates to the ROS 2 node name identifier, the Docker entrypoint command, the CI/CD workflow, and the documentation examples.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: renaming a ROS 2 publisher component to a node across multiple files and configurations.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sgrizan/branch2

Comment @coderabbitai help to get the list of available commands and usage tips.

@sgrizan-nv sgrizan-nv enabled auto-merge (squash) April 9, 2026 07:38
@sgrizan-nv sgrizan-nv merged commit a9f4373 into main Apr 9, 2026
62 of 70 checks passed
@sgrizan-nv sgrizan-nv deleted the sgrizan/branch2 branch April 9, 2026 07:41
@github-project-automation github-project-automation Bot moved this from TODO to DONE in Isaac Teleop Planning Apr 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiwenc-nv jiwenc-nv jiwenc-nv approved these changes

Assignees

@sgrizan-nv sgrizan-nv

Labels

None yet

Projects

Isaac Teleop Planning
Status: DONE

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sgrizan-nv @jiwenc-nv