Use Teleop Core retargeters instead of custom code in the ROS 2 node#373
Use Teleop Core retargeters instead of custom code in the ROS 2 node#373sgrizan-nv wants to merge 1 commit intomainfrom
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis change refactors transform handling in the teleop_ros2_publisher by shifting from client-side pose mutation to retargeting-engine pipeline inputs. The Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Key review focuses:
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@examples/teleop_ros2/python/teleop_ros2_publisher.py`:
- Around line 789-800: The block handling result["finger_joints"] should first
guard against None like the other fields (e.g., left_hand/right_hand and
left_ctrl/right_ctrl); update the controller_teleop branch to check
result["finger_joints"].is_none (or truthiness) before calling
_joint_names_from_group or list(finger_joints) and only build/publish the
JointState (finger_joints_msg) when finger_joints is present; reference the
variables/functions self._mode == "controller_teleop", result["finger_joints"],
_joint_names_from_group, and self._pub_finger_joints.publish to locate where to
add the guard.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 966a451a-3374-4124-85de-b58a5bf2bd02
📒 Files selected for processing (1)
examples/teleop_ros2/python/teleop_ros2_publisher.py
59e6466 to
f16b94e
Compare
f16b94e to
19c0f3c
Compare
Summary by CodeRabbit
New Features
Refactor