Repository navigation
Conversation
ccharly
marked this pull request as draft
November 3, 2026 14:48
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #11241.
Validation
Note
Low Risk
Observability-only refactor around existing mutex and atomic dispatch paths; locking semantics and secret handling are unchanged aside from new debug logs.
Overview
Adds opt-in lock timing diagnostics for
@metamask/keyring-controllerviaDEBUG=metamask:keyring-controller*, without changing mutex behavior.Mutex handling moves into a dedicated
withLockhelper that logs correlatedLock requested/Lock acquired/Lock released/Locked operation finishedevents for the controller and vault mutexes, with monotonicwaitMs,holdMs,totalMs, andsuccess.KeyringControllernow passes operation name labels (e.g.withKeyring,atomicUpdate,submitPassword) into every locked path so logs are attributable.Atomic keyring work gets separate start/finish logs for the full operation run outside the controller lock, while
atomicUpdatestill shows up only as short controller-side commit windows. Logs deliberately exclude arguments, results, and error text.Reviewed by Cursor Bugbot for commit e4a7bcb. Bugbot is set up for automated code reviews on this repo. Configure here.