Repository navigation
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
ccharly
force-pushed
the
cc/feat/keyring-controller-vault-transactions-atomic
branch
from
November 3, 2026 13:15
6f0d029 to
35a1050
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Adding support for a new class of keyrings that will uses inverted lock logic. Instead of locking the vault mutex and run the keyring operation, the keyring will automatically make atomic updates whenever it needs it.
This means, atomic keyring references are stable and never really destroyed (unless the vault is getting locked).
This keep the same lock properties as before, only 1 keyring mutation operation will mutate the vault, there's no concurrent execution. Atomic updates are meant to be super fast (only state updates, the atomic keyring are not meant to hold on the mutex for too long).
References
Checklist