Skip to content

Use messages key instead of string #trivial - #1365

Merged
austinwright merged 4 commits into
masterfrom
Use-messagesKey-instead-of-string
Jun 1, 2020
Merged

austinwright merged 4 commits into
masterfrom
Use-messagesKey-instead-of-string

Conversation

@austinwright

Copy link
Copy Markdown
Contributor

What does this implement/fix? Explain your changes.

See #1364.

musa-almatri and others added 2 commits June 1, 2020 18:16
messagesKey was initialized but not used
Use messagesKey instead of string

@martinpucik martinpucik left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Comment thread Example/Sources/Settings+UserDefaults.swift Outdated
Comment thread Example/Sources/Settings+UserDefaults.swift Outdated
@austinwright austinwright changed the title Use messages key instead of string Use messages key instead of string #trivial Jun 1, 2020
@austinwright austinwright changed the title Use messages key instead of string #trivial Use messages key instead of string #trivial Jun 1, 2020
@austinwright
austinwright marked this pull request as draft June 1, 2020 18:07
@austinwright
austinwright marked this pull request as ready for review June 1, 2020 18:08
@austinwright
austinwright merged commit 530b63e into master Jun 1, 2020
@austinwright
austinwright deleted the Use-messagesKey-instead-of-string branch June 1, 2020 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants